Oh dear. I regret to inform you that commit 775e241e9c5f2b2ff2b59972ab70e5f20763fae6 might be unfortunate

Oh dear. I regret to inform you that commit 775e241e9c5f2b2ff2b59972ab70e5f20763fae6 might be unfortunate

[gdb-buildbot]

My lords, ladies, gentlemen, members of the public.

It is a matter of great regret and sadness to inform you that commit:

	Import readline 7.0 (patch 5)
	775e241e9c5f2b2ff2b59972ab70e5f20763fae6

might have made GDB unwell.  Since I am just your Butler BuildBot,
I kindly ask that a human superior officer double-check this.

Please note that if you are reading this message on gdb-patches, there might
be other builders broken.

You can find more details about the unfortunate breakage in the next messages.

Cheers,

Your GDB BuildBot.

Breakage on builder Fedora-x86_64-w64-mingw32, revision 775e241e9c5f2b2ff2b59972ab70e5f20763fae6

[gdb-buildbot]

Unfortunately it seems that there is a breakage on GDB.

Commit title: 'Import readline 7.0 (patch 5)'
Revision: 775e241e9c5f2b2ff2b59972ab70e5f20763fae6

You can find more details below:

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+


+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

checking whether getlogin is declared without a macro... no
checking whether getlogin_r is declared without a macro... no
checking whether getpagesize is declared without a macro... no
checking whether getusershell is declared without a macro... no
checking whether setusershell is declared without a macro... no
checking whether endusershell is declared without a macro... no
checking whether group_member is declared without a macro... no
checking whether isatty is declared without a macro... yes
checking whether lchown is declared without a macro... no
checking whether link is declared without a macro... no
checking whether linkat is declared without a macro... no
checking whether lseek is declared without a macro... yes
checking whether pipe is declared without a macro... no
checking whether pipe2 is declared without a macro... no
checking whether pread is declared without a macro... no
checking whether pwrite is declared without a macro... no
checking whether readlink is declared without a macro... no
checking whether readlinkat is declared without a macro... no
checking whether rmdir is declared without a macro... yes
checking whether sethostname is declared without a macro... no
checking whether sleep is declared without a macro... yes
checking whether symlink is declared without a macro... no
checking whether symlinkat is declared without a macro... no
checking whether ttyname_r is declared without a macro... no
checking whether unlink is declared without a macro... yes
checking whether unlinkat is declared without a macro... no
checking whether usleep is declared without a macro... yes
checking for unsetenv... no
checking whether btowc is declared without a macro... yes
checking whether wctob is declared without a macro... yes
checking whether mbsinit is declared without a macro... yes
checking whether mbrtowc is declared without a macro... yes
checking whether mbrlen is declared without a macro... yes
checking whether mbsrtowcs is declared without a macro... yes
checking whether mbsnrtowcs is declared without a macro... no
checking whether wcrtomb is declared without a macro... yes
checking whether wcsrtombs is declared without a macro... yes
checking whether wcsnrtombs is declared without a macro... no
checking whether wcwidth is declared without a macro... no
checking whether wmemchr is declared without a macro... yes
checking whether wmemcmp is declared without a macro... yes
checking whether wmemcpy is declared without a macro... yes
checking whether wmemmove is declared without a macro... yes
checking whether wmemset is declared without a macro... yes
checking whether wcslen is declared without a macro... yes
checking whether wcsnlen is declared without a macro... yes
checking whether wcscpy is declared without a macro... yes
checking whether wcpcpy is declared without a macro... no
checking whether wcsncpy is declared without a macro... yes
checking whether wcpncpy is declared without a macro... no
checking whether wcscat is declared without a macro... yes
checking whether wcsncat is declared without a macro... yes
checking whether wcscmp is declared without a macro... yes
checking whether wcsncmp is declared without a macro... yes
checking whether wcscasecmp is declared without a macro... no
checking whether wcsncasecmp is declared without a macro... no
checking whether wcscoll is declared without a macro... yes
checking whether wcsxfrm is declared without a macro... yes
checking whether wcsdup is declared without a macro... yes
checking whether wcschr is declared without a macro... yes
checking whether wcsrchr is declared without a macro... yes
checking whether wcscspn is declared without a macro... yes
checking whether wcsspn is declared without a macro... yes
checking whether wcspbrk is declared without a macro... yes
checking whether wcsstr is declared without a macro... yes
checking whether wcstok is declared without a macro... yes
checking whether wcswidth is declared without a macro... no
checking whether iswcntrl works... guessing yes
checking for towlower... yes
checking for wctype_t... yes
checking for wctrans_t... yes
checking whether wctype is declared without a macro... yes
checking whether iswctype is declared without a macro... yes
checking whether wctrans is declared without a macro... yes
checking whether towctrans is declared without a macro... yes
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for x86_64-w64-mingw32-strip... x86_64-w64-mingw32-strip
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking whether make supports nested variables... yes
checking dependency style of x86_64-w64-mingw32-gcc... gcc3
checking whether make supports nested variables... (cached) yes
checking whether ln -s works... yes
checking for x86_64-w64-mingw32-ranlib... x86_64-w64-mingw32-ranlib
checking for x86_64-w64-mingw32-ar... (cached) x86_64-w64-mingw32-ar
configure: updating cache ./config.cache
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating import/Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing default commands
make[1]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build'
make: *** [Makefile:859: all] Error 2
program finished with exit code 2
elapsedTime=90.750819

Re: Breakage on builder Fedora-x86_64-w64-mingw32, revision 775e241e9c5f2b2ff2b59972ab70e5f20763fae6

[Christian Biesinger via gdb-patches]

The errors are:

../../binutils-gdb/readline/histfile.c:614:9: warning: implicit
declaration of function 'chown' [-Wimplicit-function-declaration]

../../binutils-gdb/readline/colors.c:173:27: warning: implicit
declaration of function 'S_ISLNK'; did you mean 'S_ISBLK'?
[-Wimplicit-function-declaration]

../../binutils-gdb/readline/colors.c:186:23: error: 'S_ISUID'
undeclared (first use in this function); did you mean 'S_ISDIR'?

../../binutils-gdb/readline/colors.c:188:28: error: 'S_ISGID'
undeclared (first use in this function); did you mean 'S_ISDIR'?

../../binutils-gdb/readline/colors.c:218:16: warning: implicit
declaration of function 'S_ISSOCK'; did you mean 'S_ISBLK'?
[-Wimplicit-function-declaration]

I guess when I tested Windows it was using different headers that had
those declarations...

Christian

On Mon, Aug 12, 2019 at 3:14 PM <gdb-buildbot@sergiodj.net> wrote:
>
> Unfortunately it seems that there is a breakage on GDB.
>
> Commit title: 'Import readline 7.0 (patch 5)'
> Revision: 775e241e9c5f2b2ff2b59972ab70e5f20763fae6
>
> You can find more details below:
>
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
>
> +++ The full log is too big to be posted here.
> +++ These are the last 100 lines of it.
>
> checking whether getlogin is declared without a macro... no
> checking whether getlogin_r is declared without a macro... no
> checking whether getpagesize is declared without a macro... no
> checking whether getusershell is declared without a macro... no
> checking whether setusershell is declared without a macro... no
> checking whether endusershell is declared without a macro... no
> checking whether group_member is declared without a macro... no
> checking whether isatty is declared without a macro... yes
> checking whether lchown is declared without a macro... no
> checking whether link is declared without a macro... no
> checking whether linkat is declared without a macro... no
> checking whether lseek is declared without a macro... yes
> checking whether pipe is declared without a macro... no
> checking whether pipe2 is declared without a macro... no
> checking whether pread is declared without a macro... no
> checking whether pwrite is declared without a macro... no
> checking whether readlink is declared without a macro... no
> checking whether readlinkat is declared without a macro... no
> checking whether rmdir is declared without a macro... yes
> checking whether sethostname is declared without a macro... no
> checking whether sleep is declared without a macro... yes
> checking whether symlink is declared without a macro... no
> checking whether symlinkat is declared without a macro... no
> checking whether ttyname_r is declared without a macro... no
> checking whether unlink is declared without a macro... yes
> checking whether unlinkat is declared without a macro... no
> checking whether usleep is declared without a macro... yes
> checking for unsetenv... no
> checking whether btowc is declared without a macro... yes
> checking whether wctob is declared without a macro... yes
> checking whether mbsinit is declared without a macro... yes
> checking whether mbrtowc is declared without a macro... yes
> checking whether mbrlen is declared without a macro... yes
> checking whether mbsrtowcs is declared without a macro... yes
> checking whether mbsnrtowcs is declared without a macro... no
> checking whether wcrtomb is declared without a macro... yes
> checking whether wcsrtombs is declared without a macro... yes
> checking whether wcsnrtombs is declared without a macro... no
> checking whether wcwidth is declared without a macro... no
> checking whether wmemchr is declared without a macro... yes
> checking whether wmemcmp is declared without a macro... yes
> checking whether wmemcpy is declared without a macro... yes
> checking whether wmemmove is declared without a macro... yes
> checking whether wmemset is declared without a macro... yes
> checking whether wcslen is declared without a macro... yes
> checking whether wcsnlen is declared without a macro... yes
> checking whether wcscpy is declared without a macro... yes
> checking whether wcpcpy is declared without a macro... no
> checking whether wcsncpy is declared without a macro... yes
> checking whether wcpncpy is declared without a macro... no
> checking whether wcscat is declared without a macro... yes
> checking whether wcsncat is declared without a macro... yes
> checking whether wcscmp is declared without a macro... yes
> checking whether wcsncmp is declared without a macro... yes
> checking whether wcscasecmp is declared without a macro... no
> checking whether wcsncasecmp is declared without a macro... no
> checking whether wcscoll is declared without a macro... yes
> checking whether wcsxfrm is declared without a macro... yes
> checking whether wcsdup is declared without a macro... yes
> checking whether wcschr is declared without a macro... yes
> checking whether wcsrchr is declared without a macro... yes
> checking whether wcscspn is declared without a macro... yes
> checking whether wcsspn is declared without a macro... yes
> checking whether wcspbrk is declared without a macro... yes
> checking whether wcsstr is declared without a macro... yes
> checking whether wcstok is declared without a macro... yes
> checking whether wcswidth is declared without a macro... no
> checking whether iswcntrl works... guessing yes
> checking for towlower... yes
> checking for wctype_t... yes
> checking for wctrans_t... yes
> checking whether wctype is declared without a macro... yes
> checking whether iswctype is declared without a macro... yes
> checking whether wctrans is declared without a macro... yes
> checking whether towctrans is declared without a macro... yes
> checking for a BSD-compatible install... /usr/bin/install -c
> checking whether build environment is sane... yes
> checking for x86_64-w64-mingw32-strip... x86_64-w64-mingw32-strip
> checking for gawk... gawk
> checking whether make sets $(MAKE)... yes
> checking for style of include used by make... GNU
> checking whether make supports nested variables... yes
> checking dependency style of x86_64-w64-mingw32-gcc... gcc3
> checking whether make supports nested variables... (cached) yes
> checking whether ln -s works... yes
> checking for x86_64-w64-mingw32-ranlib... x86_64-w64-mingw32-ranlib
> checking for x86_64-w64-mingw32-ar... (cached) x86_64-w64-mingw32-ar
> configure: updating cache ./config.cache
> checking that generated files are newer than configure... done
> configure: creating ./config.status
> config.status: creating Makefile
> config.status: creating import/Makefile
> config.status: creating config.h
> config.status: executing depfiles commands
> config.status: executing default commands
> make[1]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build'
> make: *** [Makefile:859: all] Error 2
> program finished with exit code 2
> elapsedTime=90.750819

Re: Breakage on builder Fedora-x86_64-w64-mingw32, revision 775e241e9c5f2b2ff2b59972ab70e5f20763fae6

[Tom Tromey]

>>>>> "Christian" == Christian Biesinger <cbiesinger@google.com> writes:

Christian> I guess when I tested Windows it was using different headers that had
Christian> those declarations...

I suspect it's fixed in a later patch.
If the bot gets to the end of the series & there are still problems, I
think we should fix them by adding a patch on top.

Tom