Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/tdep] Handle mxcsr kernel bug on Intel Skylake CPUs
Date: Tue, 24 Sep 2019 20:06:00 -0000	[thread overview]
Message-ID: <87lfudmpbu.fsf@tromey.com> (raw)
In-Reply-To: <20190924131612.GA24708@delia> (Tom de Vries's message of "Tue,	24 Sep 2019 15:16:14 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> [gdb/tdep] Handle mxcsr kernel bug on Intel Skylake CPUs

Tom> gdb/ChangeLog:

Tom> 2019-09-24  Tom de Vries  <tdevries@suse.de>

Tom> 	PR gdb/23815
Tom> 	* amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
Tom> 	Initialize xstateregs before ptrace PTRACE_GETREGSET call.

Thanks for the patch.

I think this is reasonable, but it could use a comment before the memset
explaining why it is there.  Maybe some future gdb hacker will want to
remove the memset, and a comment would explain why not to, or when it
would be ok to.

thanks,
Tom


  reply	other threads:[~2019-09-24 20:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 13:16 Tom de Vries
2019-09-24 20:06 ` Tom Tromey [this message]
2019-09-25  7:07   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfudmpbu.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox