From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43757 invoked by alias); 24 Sep 2019 20:06:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43749 invoked by uid 89); 24 Sep 2019 20:06:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=hacker X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Sep 2019 20:06:32 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 0706127FE for ; Tue, 24 Sep 2019 15:06:31 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Cr4wis21RiQerCr4wi6Fxo; Tue, 24 Sep 2019 15:06:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=R7HQcpr+d0QFcq6z0Oq5PpniFH8bHgvY69qIeVrTc/c=; b=AI/lmYEib+riKwe/mt6lT3gPx7 sWydRY1zdUfdHp1dTbBLj2Pf3uDnmDMwjBf7J9ubBMGnu7iwvqqBwXOxE39PdrJHC0b4hoijMzMXd OajwrmB9iwX/b2jFHzK8pUx7P; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:40442 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iCr4w-001QsR-Jl; Tue, 24 Sep 2019 15:06:30 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/tdep] Handle mxcsr kernel bug on Intel Skylake CPUs References: <20190924131612.GA24708@delia> Date: Tue, 24 Sep 2019 20:06:00 -0000 In-Reply-To: <20190924131612.GA24708@delia> (Tom de Vries's message of "Tue, 24 Sep 2019 15:16:14 +0200") Message-ID: <87lfudmpbu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00469.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> [gdb/tdep] Handle mxcsr kernel bug on Intel Skylake CPUs Tom> gdb/ChangeLog: Tom> 2019-09-24 Tom de Vries Tom> PR gdb/23815 Tom> * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers): Tom> Initialize xstateregs before ptrace PTRACE_GETREGSET call. Thanks for the patch. I think this is reasonable, but it could use a comment before the memset explaining why it is there. Maybe some future gdb hacker will want to remove the memset, and a comment would explain why not to, or when it would be ok to. thanks, Tom