From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH][gdb] Fix cc-with-dwz regression
Date: Thu, 20 Feb 2020 16:43:00 -0000 [thread overview]
Message-ID: <87lfoxnr9t.fsf@tromey.com> (raw)
In-Reply-To: <20200220142547.GA16577@delia> (Tom de Vries's message of "Thu, 20 Feb 2020 15:25:49 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Hi,
Tom> I noticed a regression with board cc-with-dwz:
Tom> ...
Tom> FAIL: gdb.cp/m-static.exp: static const int initialized elsewhere
Tom> FAIL: gdb.cp/m-static.exp: info variable everywhere
Tom> ...
Tom> The problem started with commit 0494dbecdf "Consolidate partial symtab
Tom> dependency reading".
Thank you for doing this.
Tom> The commit replaces the dwarf2_psymtab::expand_psymtab specific reading of
Tom> dependencies, which contains a "dependencies[i]->user == NULL" test, with a
Tom> generic partial_symtab::read_dependencies call, which does not test the user
Tom> field.
Can we simply add this to the base class?
I think only the DWARF reader ever sets the "user" field anyway.
Tom
next prev parent reply other threads:[~2020-02-20 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 14:25 Tom de Vries
2020-02-20 16:43 ` Tom Tromey [this message]
2020-02-21 13:02 ` Tom de Vries
2020-02-21 14:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfoxnr9t.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox