From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41620 invoked by alias); 20 Feb 2020 16:43:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41607 invoked by uid 89); 20 Feb 2020 16:43:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:807 X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.196.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Feb 2020 16:43:29 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 1EBEB9FA9 for ; Thu, 20 Feb 2020 10:43:28 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4ov9jbOYXSl8q4ov9jHiBZ; Thu, 20 Feb 2020 10:43:28 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fFWr40JdHbL6a7a/s4W0c0zEtLOKuFBuwJSu6GH9GvY=; b=Lyef0Rfq9S8Qa1mUw2k3V7fd/i rG8+BC0DzxqYqaIWzO2nYxxUDNmVJrzhwY/EwtfUnvyaCKLwjOBBoVQloPQsL0TJV1eeN+cS39p7F X/tOadPHmf5vr+PGMebkEdgU7; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:56088 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j4ov9-001HNL-BY; Thu, 20 Feb 2020 09:43:27 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH][gdb] Fix cc-with-dwz regression References: <20200220142547.GA16577@delia> Date: Thu, 20 Feb 2020 16:43:00 -0000 In-Reply-To: <20200220142547.GA16577@delia> (Tom de Vries's message of "Thu, 20 Feb 2020 15:25:49 +0100") Message-ID: <87lfoxnr9t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00828.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> Hi, Tom> I noticed a regression with board cc-with-dwz: Tom> ... Tom> FAIL: gdb.cp/m-static.exp: static const int initialized elsewhere Tom> FAIL: gdb.cp/m-static.exp: info variable everywhere Tom> ... Tom> The problem started with commit 0494dbecdf "Consolidate partial symtab Tom> dependency reading". Thank you for doing this. Tom> The commit replaces the dwarf2_psymtab::expand_psymtab specific reading of Tom> dependencies, which contains a "dependencies[i]->user == NULL" test, with a Tom> generic partial_symtab::read_dependencies call, which does not test the user Tom> field. Can we simply add this to the base class? I think only the DWARF reader ever sets the "user" field anyway. Tom