From: Tom Tromey <tom@tromey.com>
To: Caroline Tice via Gdb-patches <gdb-patches@sourceware.org>
Cc: Caroline Tice <cmtice@google.com>,
Eric Christopher <echristo@google.com>
Subject: Re: [PATCH] Fix issues with reading rnglists, especially from dwo files, for DWARF v5
Date: Mon, 01 Jun 2020 14:33:27 -0600 [thread overview]
Message-ID: <87lfl634rs.fsf@tromey.com> (raw)
In-Reply-To: <CABtf2+QjPQnDZWKOhJ_b-n3SWVPfS1AfYVkNgHHmBSqS+3+UPw@mail.gmail.com> (Caroline Tice via Gdb-patches's message of "Mon, 1 Jun 2020 10:16:52 -0700")
>>>>> "Caroline" == Caroline Tice via Gdb-patches <gdb-patches@sourceware.org> writes:
Caroline> This patch fixes these issues. I verified that it fixes the
Caroline> issues I saw and that it does not cause any testsuite
Caroline> regressions (on x86_64 ubuntu linux).
Is there a way to reproduce the failures with the current test suite?
Say, by running some test using some board file?
Caroline> @@ -793,12 +796,18 @@ struct virtual_v2_dwo_sections
Caroline> bfd_size_type loc_offset;
Caroline> bfd_size_type loc_size;
Caroline> + bfd_size_type loclists_offset;
Caroline> + bfd_size_type loclists_size;
Caroline> +
Caroline> bfd_size_type macinfo_offset;
Caroline> bfd_size_type macinfo_size;
Caroline> bfd_size_type macro_offset;
Caroline> bfd_size_type macro_size;
Caroline> + bfd_size_type rnglists_offset;
Caroline> + bfd_size_type rnglists_size;
These new members don't seem to be used anywhere.
Caroline> +static struct dwarf2_section_info *cu_debug_rnglist_section (struct
Caroline> + dwarf2_cu *cu);
Probably better to split before the "(" and then indent the continuation
line 2 spaces.
Caroline> - default:
Caroline> + case DW_RLE_startx_endx:
Looks like the indentation here is incorrect.
Caroline> +
Caroline> + attr = die->attr (DW_AT_rnglists_base);
Extra space after the "=".
Tom
next prev parent reply other threads:[~2020-06-01 20:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 17:16 Caroline Tice
2020-06-01 20:33 ` Tom Tromey [this message]
2020-06-02 17:04 ` Caroline Tice
2020-06-03 14:49 ` Tom Tromey
2020-06-04 21:39 ` Caroline Tice
2020-06-09 23:32 ` Caroline Tice
2020-06-16 15:37 ` Caroline Tice
2020-06-18 20:27 ` Tom Tromey
2020-06-23 19:04 ` Caroline Tice
2020-07-01 0:09 ` Caroline Tice
2020-07-01 0:34 ` Simon Marchi
2020-07-01 0:36 ` Simon Marchi
2020-07-01 19:57 ` Caroline Tice
2020-07-02 5:41 ` Simon Marchi
2020-07-03 22:47 ` [PATCH V3] " Caroline Tice
2020-07-04 5:11 ` Simon Marchi
2020-07-09 15:48 ` [PATCH V4] " Caroline Tice
2020-07-11 17:54 ` Simon Marchi
2020-07-14 15:47 ` [PATCH V5] " Caroline Tice
2020-07-15 2:04 ` Simon Marchi
2020-07-15 3:15 ` Simon Marchi
2020-07-15 16:57 ` Caroline Tice
2020-07-15 17:04 ` H.J. Lu
2020-07-15 22:35 ` Caroline Tice
2020-07-16 2:34 ` Simon Marchi
2020-07-16 4:46 ` Caroline Tice
2020-07-16 15:41 ` Simon Marchi
2020-07-16 15:46 ` Caroline Tice
2020-07-16 16:09 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfl634rs.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cmtice@google.com \
--cc=echristo@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox