From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.49.60]) by sourceware.org (Postfix) with ESMTPS id 356563851C37 for ; Mon, 1 Jun 2020 20:33:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 356563851C37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id BB1ADABD9 for ; Mon, 1 Jun 2020 15:33:28 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fr7gjh2lUEfyqfr7gjLqVc; Mon, 01 Jun 2020 15:33:28 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FXZKQ92URwEzHYfkQviuYSwh665H95JYfKirX0qGM68=; b=XMOntJSqsMEJ3Qpc5IpO0WEwTk zf4Lb0o/bvOFGLjPg51mvmzy4NvRI21ISdXnUdSDt3qSIcPVH3AxFqwwF8T33q7F6SAGpFvlFtSjO z3/YAWa1ni77mYHzd9p7cUbM0; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:58534 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jfr7g-003NwF-FG; Mon, 01 Jun 2020 14:33:28 -0600 From: Tom Tromey To: Caroline Tice via Gdb-patches Cc: Caroline Tice , Eric Christopher Subject: Re: [PATCH] Fix issues with reading rnglists, especially from dwo files, for DWARF v5 References: X-Attribution: Tom Date: Mon, 01 Jun 2020 14:33:27 -0600 In-Reply-To: (Caroline Tice via Gdb-patches's message of "Mon, 1 Jun 2020 10:16:52 -0700") Message-ID: <87lfl634rs.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jfr7g-003NwF-FG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:58534 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, KAM_NUMSUBJECT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 20:33:31 -0000 >>>>> "Caroline" == Caroline Tice via Gdb-patches writes: Caroline> This patch fixes these issues. I verified that it fixes the Caroline> issues I saw and that it does not cause any testsuite Caroline> regressions (on x86_64 ubuntu linux). Is there a way to reproduce the failures with the current test suite? Say, by running some test using some board file? Caroline> @@ -793,12 +796,18 @@ struct virtual_v2_dwo_sections Caroline> bfd_size_type loc_offset; Caroline> bfd_size_type loc_size; Caroline> + bfd_size_type loclists_offset; Caroline> + bfd_size_type loclists_size; Caroline> + Caroline> bfd_size_type macinfo_offset; Caroline> bfd_size_type macinfo_size; Caroline> bfd_size_type macro_offset; Caroline> bfd_size_type macro_size; Caroline> + bfd_size_type rnglists_offset; Caroline> + bfd_size_type rnglists_size; These new members don't seem to be used anywhere. Caroline> +static struct dwarf2_section_info *cu_debug_rnglist_section (struct Caroline> + dwarf2_cu *cu); Probably better to split before the "(" and then indent the continuation line 2 spaces. Caroline> - default: Caroline> + case DW_RLE_startx_endx: Looks like the indentation here is incorrect. Caroline> + Caroline> + attr = die->attr (DW_AT_rnglists_base); Extra space after the "=". Tom