From: Tom Tromey <tom@tromey.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Pedro Alves <palves@redhat.com>, Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 3/8] Introduce gdb-specific %p format suffixes
Date: Fri, 27 Aug 2021 14:17:23 -0600 [thread overview]
Message-ID: <87lf4mmylo.fsf@tromey.com> (raw)
In-Reply-To: <87im0386sh.fsf@igel.home> (Andreas Schwab's message of "Wed, 18 Aug 2021 11:02:22 +0200")
>>>>> "Andreas" == Andreas Schwab <schwab@linux-m68k.org> writes:
Andreas> On Sep 27 2019, Tom Tromey wrote:
>> void
>> vfprintf_filtered (struct ui_file *stream, const char *format, va_list args)
>> {
>> - vfprintf_maybe_filtered (stream, format, args, 1);
>> + vfprintf_maybe_filtered (stream, format, args, true, true);
>> }
>> void
>> vprintf_filtered (const char *format, va_list args)
>> {
>> - vfprintf_maybe_filtered (gdb_stdout, format, args, 1);
>> + vfprintf_maybe_filtered (gdb_stdout, format, args, true, false);
>> }
Andreas> Why is vprintf_filtered different from vfprintf_filtered (gdb_stdout)?
I don't know. Changing that 'false' to 'true' doesn't cause any
regressions. And abstractly that seems like the right thing to do.
There's another thread about this as well, I'll reply there too.
Tom
next prev parent reply other threads:[~2021-08-27 20:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 21:25 [PATCH 0/8] More gdb styling improvements Tom Tromey
2019-09-27 21:25 ` [PATCH 7/8] Use styled_string in more places Tom Tromey
2019-09-27 21:25 ` [PATCH 2/8] Don't create empty literal pieces Tom Tromey
2019-09-27 21:25 ` [PATCH 5/8] Style "pwd" output Tom Tromey
2019-09-27 21:25 ` [PATCH 3/8] Introduce gdb-specific %p format suffixes Tom Tromey
2019-09-30 14:06 ` Pedro Alves
2021-08-18 9:02 ` Andreas Schwab
2021-08-27 20:17 ` Tom Tromey [this message]
2019-09-27 21:25 ` [PATCH 4/8] Use new %p format suffixes in gdb Tom Tromey
2019-09-30 14:05 ` Pedro Alves
2019-09-27 21:25 ` [PATCH 8/8] Use styled_string for "show logging filename" Tom Tromey
2019-09-27 21:25 ` [PATCH 1/8] Remove the ui_out_style_kind enum Tom Tromey
2019-09-27 21:25 ` [PATCH 6/8] Introduce metadata style Tom Tromey
2019-09-30 14:07 ` Pedro Alves
2019-09-30 14:09 ` [PATCH 0/8] More gdb styling improvements Pedro Alves
2019-10-01 21:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf4mmylo.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox