From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9aywMmtIKWFOZwAAWB0awg (envelope-from ) for ; Fri, 27 Aug 2021 16:17:47 -0400 Received: by simark.ca (Postfix, from userid 112) id C01901EE1B; Fri, 27 Aug 2021 16:17:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 04DAB1ECEB for ; Fri, 27 Aug 2021 16:17:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 449E33858018 for ; Fri, 27 Aug 2021 20:17:46 +0000 (GMT) Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.50.164]) by sourceware.org (Postfix) with ESMTPS id 56E133858D34 for ; Fri, 27 Aug 2021 20:17:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56E133858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id E83EE6BA3 for ; Fri, 27 Aug 2021 15:17:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JiI0m3mXAK61iJiI0m5i97; Fri, 27 Aug 2021 15:17:24 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y0eyo2MJyRKFspUUkavYh/zPR6vNnc+fgRNBGkwK2bY=; b=RXBpCyjRLBJ6gKEFcUudlmlQyC QuJRvuw+wuReUgppt8E9tzp78smXpn6lsBUIpCaxrBHtj7ZjNgFM+U5dlvKu9CP/1jgb94GqTP0kt aMvzrI+99v6/bYxi6pcStvFTH; Received: from 97-122-86-84.hlrn.qwest.net ([97.122.86.84]:40710 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mJiI0-0041RJ-Jy; Fri, 27 Aug 2021 14:17:24 -0600 From: Tom Tromey To: Andreas Schwab Subject: Re: [PATCH 3/8] Introduce gdb-specific %p format suffixes References: <20190927212520.20073-1-tom@tromey.com> <20190927212520.20073-4-tom@tromey.com> <87im0386sh.fsf@igel.home> X-Attribution: Tom Date: Fri, 27 Aug 2021 14:17:23 -0600 In-Reply-To: <87im0386sh.fsf@igel.home> (Andreas Schwab's message of "Wed, 18 Aug 2021 11:02:22 +0200") Message-ID: <87lf4mmylo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.84 X-Source-L: No X-Exim-ID: 1mJiI0-0041RJ-Jy X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-84.hlrn.qwest.net (murgatroyd) [97.122.86.84]:40710 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pedro Alves , Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Andreas" == Andreas Schwab writes: Andreas> On Sep 27 2019, Tom Tromey wrote: >> void >> vfprintf_filtered (struct ui_file *stream, const char *format, va_list args) >> { >> - vfprintf_maybe_filtered (stream, format, args, 1); >> + vfprintf_maybe_filtered (stream, format, args, true, true); >> } >> void >> vprintf_filtered (const char *format, va_list args) >> { >> - vfprintf_maybe_filtered (gdb_stdout, format, args, 1); >> + vfprintf_maybe_filtered (gdb_stdout, format, args, true, false); >> } Andreas> Why is vprintf_filtered different from vfprintf_filtered (gdb_stdout)? I don't know. Changing that 'false' to 'true' doesn't cause any regressions. And abstractly that seems like the right thing to do. There's another thread about this as well, I'll reply there too. Tom