Re: [PATCH 3/3] gdb/testsuite: add a test to check for Python traits static_assert

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> The previous two commits added a new type trait which can be used
Andrew> within a static_assert to check the properties of a struct used by GDB
Andrew> to implement Python objects.

Andrew> The previous commit fixed a bug in GDB which this trait check exposed.

Andrew> This commit adds a new test gdb.gdb/python-traits-check.exp which
Andrew> checks that every struct in the Python/ directory that inherits from
Andrew> PyObject, has a suitable static_assert in place.

Andrew> Adding this test should mean that if someone adds a new Python object
Andrew> type to GDB, and they forget to add the static_assert, then this test
Andrew> should give a failure, which should remind them to add the required
Andrew> static_assert.  The static_assert will then check that their new
Andrew> struct is compliant.

With the "safety" work we can have the compiler check this; or if the
tp_init plan works out, I guess just drop the requirement entirely.

Approved-By: Tom Tromey <tom@tromey.com>

Tom