From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id n7hEEpdYB2qhuz0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 13:32:07 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=tWJSJg8L; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 33E8F1E0B1; Fri, 15 May 2026 13:32:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 783A01E067 for ; Fri, 15 May 2026 13:32:06 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ECE4B40A1FB9 for ; Fri, 15 May 2026 17:32:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECE4B40A1FB9 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=tWJSJg8L Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id D7B904BA2E0A for ; Fri, 15 May 2026 17:31:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D7B904BA2E0A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D7B904BA2E0A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778866301; cv=none; b=Ou8KGAKUt+cwz5TYUExISlLswmbICtJi7Gt3YjSP+Duh1HExvprN3pcXY9jBN2mLwzWOPxEbRN77ksfjppN5yse9qFSSucjBA5pb/6TdfQU/USgxT8+Iy/19OOokgrS6bADRbN3Gmgwr49VERft2fx+QLqBNEwNrJHSuj9jGwBU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778866301; c=relaxed/simple; bh=ukR3BamUKVMupieGJNEyclP6//7iyqP64WJLFSxLTn8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UDJAI8h6AvJIVsoklRCrvSKhFp7HgnVh+ABYbPnfIKpEKupBTvEXGVf0VkxPGOBROYYGbWv0nB91A9+bISGtWTaIwIAteJoqzj8r8cmuh+MDiMguTMPU2QqUL+iqdcdNHS3wfTREgp26UzAomKaIHBh/nQD+qLfNSkketreRHdY= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=tWJSJg8L reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7B904BA2E0A Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id NdwVwFiik4RkpNwNwwqIH7; Fri, 15 May 2026 17:31:40 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NwNvwO863sO4mNwNvwFWCm; Fri, 15 May 2026 17:31:39 +0000 X-Authority-Analysis: v=2.4 cv=LreSymdc c=1 sm=1 tr=0 ts=6a07587c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=gACoOk9A5NgrWZtA:21 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=VJR3K9eLKy38JDuz8FIA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/CYXqAPgy/M233eLuNY4elS7houXIoYyY+rPfvYe4YI=; b=tWJSJg8Ll3unw1vlo4t1M8nJ5+ Cj4Dh6WreD/V91ZfwVRud2YcrnsYDYtj/7UvPmfOLtrkWWZrVVIPichNIPVARYL6MOSCo0aSc4JZk 5zp4gjBkimtoxZbD9yh5huzDZ; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:44120 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wNwNu-00000001eRa-3pad; Fri, 15 May 2026 11:31:39 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] gdb/testsuite: add a test to check for Python traits static_assert In-Reply-To: <93b625c0ab2f23cafa636d42e503361b70ee6edf.1778839043.git.aburgess@redhat.com> (Andrew Burgess's message of "Fri, 15 May 2026 11:00:48 +0100") References: <93b625c0ab2f23cafa636d42e503361b70ee6edf.1778839043.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 15 May 2026 11:31:37 -0600 Message-ID: <87lddkh952.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wNwNu-00000001eRa-3pad X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:44120 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfII43H9dcA0Tjk4uq5uRJ1iaNsxZUoIYAlPucPGGpiPxYCnc9dzdmYby+F+DmKeXuSFrZGBYYLYRjSqITbmlolsjY3RruF2OHpGA5nOCtsa/Q+yeWXQe KWhpNGijFFPBOk8gm6w90b6eVd16pKTw54fRzsqfR4PR5b06PSayKuScg6Ythk+HTo2+k8HD5ViJJXRCzJaP5QnP86krCQaa5rs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> The previous two commits added a new type trait which can be used Andrew> within a static_assert to check the properties of a struct used by GDB Andrew> to implement Python objects. Andrew> The previous commit fixed a bug in GDB which this trait check exposed. Andrew> This commit adds a new test gdb.gdb/python-traits-check.exp which Andrew> checks that every struct in the Python/ directory that inherits from Andrew> PyObject, has a suitable static_assert in place. Andrew> Adding this test should mean that if someone adds a new Python object Andrew> type to GDB, and they forget to add the static_assert, then this test Andrew> should give a failure, which should remind them to add the required Andrew> static_assert. The static_assert will then check that their new Andrew> struct is compliant. With the "safety" work we can have the compiler check this; or if the tp_init plan works out, I guess just drop the requirement entirely. Approved-By: Tom Tromey Tom