Re: [PATCH v2 2/4] gdb/python: eval_python_command returns result of the evaluation

[Tom Tromey <tom@tromey.com>]

>>>>> Matthieu Longo <matthieu.longo@arm.com> writes:

> (1)
>   if (eval_python_command (...) == nullptr)
> VS (2)
>   if (! eval_python_command (...))

> As you can see below, (1) is significantly more verbose than (2) and
> makes more difficult to respect the "80 characters per line" rule.

I'm probably not the best person to advocate for this, since in olden
times I routinely wrote checks in the concise style, but anyway I think
the rationale is that of the competing interests at play, being clear &
explicit wins out over formatting.

> -  if (eval_python_command (code, Py_file_input) == 0)
> +  if (eval_python_command (code, Py_file_input) != nullptr)

Should this be == nullptr instead?

thanks,
Tom