From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QQNLFwW5DGpAaAgAWB0awg (envelope-from ) for ; Tue, 19 May 2026 15:24:53 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=P/6FRTE2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5B8141E098; Tue, 19 May 2026 15:24:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BDC9D1E024 for ; Tue, 19 May 2026 15:24:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 499BC4BB3BF4 for ; Tue, 19 May 2026 19:24:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 499BC4BB3BF4 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=P/6FRTE2 Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id CCFFC4BB3BF1 for ; Tue, 19 May 2026 19:24:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CCFFC4BB3BF1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CCFFC4BB3BF1 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779218667; cv=none; b=bLtY/Lwexxet+dI4KD2ipH2aY1WVcgmhL9kYsobNSEC2jWuk0sA5H/Xo5wQ2llfasfvoTVK8BYVzuQcncXahDAZF3XWmVKrD1ULyUhStBsQrlHn4l1Jyj2veQn/ylzi8rJNgNH/UvG2rXnGAG7Qixl7CZ2E9Y9wggrfYzquBGS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779218667; c=relaxed/simple; bh=ervQG6yd9QEb5x8W65nHbhHUWZz7SqVphXFmXOe2pjk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CKbpKQ+pxqN+hSxde/kpAGpqCuYLUbp76kTF12q6aIQF83VWeUT+e9FTBQ3vVN5DN+QSrXcysQZJjUuPVwEQw7aq7RtBzH39jAnLHXmaX9CgLi0Lq4dnZORgvyGkL70aUy4+sL/i8x9Ke6qvpzeTqv6nrlBO/p6mWroVflxEFHI= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=P/6FRTE2 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CCFFC4BB3BF1 Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id POjcwOtEwnwj2PQ3FwP30D; Tue, 19 May 2026 19:24:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id PQ37wcB9lcvlfPQ37w2xJJ; Tue, 19 May 2026 19:24:17 +0000 X-Authority-Analysis: v=2.4 cv=LtSSymdc c=1 sm=1 tr=0 ts=6a0cb8e8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=9gcfukJZRxQTurduPzQA:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/1GPQjzwrZd4+XQfdYQ8Ty+bABgt7/jmlD9ek7QpthU=; b=P/6FRTE2UWE64gpaEu7BfeZ326 OuQarork4nkEoqJ1qnmTuaHXxZA+4N29RTDMq9EScQAMt/8ZrjITV0zPcot7bYQjxdXzT//RQtbQq noaXw6xOuQBHB+eLPZ3wZtY00; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:54796 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wPQ36-00000002WsB-37hK; Tue, 19 May 2026 13:24:16 -0600 From: Tom Tromey To: Matthieu Longo Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/4] gdb/python: eval_python_command returns result of the evaluation In-Reply-To: (Matthieu Longo's message of "Mon, 18 May 2026 15:37:35 +0100") References: <20260428162416.511367-1-matthieu.longo@arm.com> <20260428162416.511367-3-matthieu.longo@arm.com> <87cxywipkx.fsf@tromey.com> X-Attribution: Tom Date: Tue, 19 May 2026 13:24:15 -0600 Message-ID: <87lddfb3ts.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wPQ36-00000002WsB-37hK X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:54796 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfL45OJ1WNo56Rg00DZndq8GXwPW7NqGy0gIUG/NzFOd/05KJSbRMys2YUTejYPFwYRIuQBk9vB3LnvKPDIVIz1uPVl5kr7etTu051efBV6SZFIWIBfNT jA33R2ExBAkgsJt1xN0FVvJhpciNK5k9bptn7Aa8oeMQUFPXDGVoBXp5LHGB0EcXqc/pO43vSZOhI5rPrum9zkDF66tOXRGvBDQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Matthieu Longo writes: > (1) > if (eval_python_command (...) == nullptr) > VS (2) > if (! eval_python_command (...)) > As you can see below, (1) is significantly more verbose than (2) and > makes more difficult to respect the "80 characters per line" rule. I'm probably not the best person to advocate for this, since in olden times I routinely wrote checks in the concise style, but anyway I think the rationale is that of the competing interests at play, being clear & explicit wins out over formatting. > - if (eval_python_command (code, Py_file_input) == 0) > + if (eval_python_command (code, Py_file_input) != nullptr) Should this be == nullptr instead? thanks, Tom