Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] [gdb/build] Fix building gdb.pot
@ 2026-06-07  7:23 Tom de Vries
  2026-06-09 16:49 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2026-06-07  7:23 UTC (permalink / raw)
  To: gdb-patches

Since commit 8708a20e2bb ("gdb: store gdbtk object files into their sources
directory"), building gdb.pot is broken.

The commit added gdbtk/generic to CONFIG_SRC_SUBDIR, and building gdb.pot
breaks because the directory doesn't exist.

Fix this by ignoring the dir while building gdb.pot.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34212
---
 gdb/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index b2b7ef3d606..2349ef7fbdf 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2697,7 +2697,7 @@ po/$(PACKAGE).pot: force
 	-test -d po || mkdir po
 	sh -e $(srcdir)/po/gdbtext $(XGETTEXT) $(PACKAGE) . $(srcdir) \
 	  $(srcdir)/../gdbsupport $(srcdir)/../gdbserver \
-	  $(addprefix $(srcdir)/,$(CONFIG_SRC_SUBDIR))
+	  $(addprefix $(srcdir)/,$(filter-out gdbtk/generic, $(CONFIG_SRC_SUBDIR)))
 
 
 #

base-commit: 4562eab73d375e57f3c5a67f62d2678d7730d7ab
-- 
2.51.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [gdb/build] Fix building gdb.pot
  2026-06-07  7:23 [PATCH] [gdb/build] Fix building gdb.pot Tom de Vries
@ 2026-06-09 16:49 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2026-06-09 16:49 UTC (permalink / raw)
  To: Tom de Vries; +Cc: gdb-patches

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Since commit 8708a20e2bb ("gdb: store gdbtk object files into their sources
Tom> directory"), building gdb.pot is broken.

Tom> The commit added gdbtk/generic to CONFIG_SRC_SUBDIR, and building gdb.pot
Tom> breaks because the directory doesn't exist.

Tom> Fix this by ignoring the dir while building gdb.pot.

Looks good to me.  I guess if Insight wants to use this machinery it
will need some extra work here.

Approved-By: Tom Tromey <tom@tromey.com>

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-09 16:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-07  7:23 [PATCH] [gdb/build] Fix building gdb.pot Tom de Vries
2026-06-09 16:49 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox