From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb/linux-tdep: clearer variable names in linux_get_siginfo_type
Date: Fri, 21 Aug 2026 09:20:51 -0600 [thread overview]
Message-ID: <87ld9zsdnw.fsf@tromey.com> (raw)
In-Reply-To: <20260813161905.345483-1-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 13 Aug 2026 12:18:58 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> Instead of reusing the single variable `type`, use distinct variables
Simon> for the various types created. I find it more readable this way, it's
Simon> easier to track what's being added to what.
Simon> Do other cleanups at the same time, like NULL -> nullptr, removing some
Simon> `struct` keywords, and moving variable declarations to the point of
Simon> first use.
Looks good, thanks.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-08-21 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 16:18 Simon Marchi
2026-08-13 16:18 ` [PATCH 2/2] gdb: pass type name directly to arch_composite_type Simon Marchi
2026-08-21 15:23 ` Tom Tromey
2026-08-21 15:20 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ld9zsdnw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox