From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AGx7AQhtiGq/+TMAWB0awg (envelope-from ) for ; Fri, 21 Aug 2026 11:21:44 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=xWjzpVx6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ED2A91E033; Fri, 21 Aug 2026 11:21:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0595B1E033 for ; Fri, 21 Aug 2026 11:21:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 913CF4BB24C4 for ; Fri, 21 Aug 2026 15:21:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 913CF4BB24C4 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=xWjzpVx6 Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 2C3DD4B99F74 for ; Fri, 21 Aug 2026 15:20:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C3DD4B99F74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2C3DD4B99F74 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787325654; cv=none; b=wpv/1gEVdyRlNPYWslx+ntGGs17OZQiURfFMVJ5h3ETReTs0Dq4t+krK2tEeRYjTIgasMOSL8J7bwLksfVUX8tnv2Z3rs6e//IPxpF1lFRH20XTpKQNtS7zftGvk+YbZBqaRUCNnOmeArGROWM7aiS7WXxeqJ7HbkSALSoURhNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787325654; c=relaxed/simple; bh=w9Ehc6PHTV5uDzwTpHe59PiqfYYpbC08CWEdoTIuK2o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XDliunbnAaeglnzzsSrYX/1FTX9tI20w8hY4xEzywu+OlKL6jhXYy/D6wSwhjPahPQc9wemozNhRooyQHaCJCvwlzNRzUybgpxLDIXkRoGdH4u4N8X/+DKQrk1Pu3Yi1tFzYY8sHse+fnZYT9FUdE/LBubhPtsypVFP17HqeJLM= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=xWjzpVx6 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C3DD4B99F74 Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id xPLMwl2cUJFmFxR37wYbqL; Fri, 21 Aug 2026 15:20:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xR37wcIx18SaOxR37wHDt4; Fri, 21 Aug 2026 15:20:53 +0000 X-Authority-Analysis: v=2.4 cv=CKoqXQrD c=1 sm=1 tr=0 ts=6a886cd5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=9Snt7YAv5TAVieCxs3sA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7YohiNe6/H+RPVkRy3mZJXOBFgCReUNjk0WyQ+tLnGQ=; b=xWjzpVx6CmXxsO/A+o4XPO4xko 4B6pKwRekDf5ebY7mLK/NNS6SKShYJ0Ho8CGbmF1rRk2Esh8Jb2fu1RNJwAuvZcd24lDueJ9KsB90 jLCbHxofMV8Kbr2zr2qNSJi62; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:59328 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wxR36-000000042Wh-3Ovw; Fri, 21 Aug 2026 09:20:52 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb/linux-tdep: clearer variable names in linux_get_siginfo_type In-Reply-To: <20260813161905.345483-1-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 13 Aug 2026 12:18:58 -0400") References: <20260813161905.345483-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 21 Aug 2026 09:20:51 -0600 Message-ID: <87ld9zsdnw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wxR36-000000042Wh-3Ovw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:59328 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFgjkeCpY7V0brSOs/cfmpU81l8ySdKfsrIxZ/Yg82H/4fEpACJ6qer8aeCeBmD4/OIhVFtDowZYvuFaDdVQJ/3MjHhGpodWNvj5ZGJyw1Xkyr+LGLZX fT4JFpU6c6c97ycpoDkeTBROnlqo4EfrNs4YL/8j866JC6pf4Dks25KyEtZLkmcYIg71T7bJE7knYqgzFXLdSsxpDTJM1g3M5So= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> Instead of reusing the single variable `type`, use distinct variables Simon> for the various types created. I find it more readable this way, it's Simon> easier to track what's being added to what. Simon> Do other cleanups at the same time, like NULL -> nullptr, removing some Simon> `struct` keywords, and moving variable declarations to the point of Simon> first use. Looks good, thanks. Approved-By: Tom Tromey Tom