Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Sandiford <richard@codesourcery.com>
To: gcc-patches@gcc.gnu.org
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Allow sysroots to be relocated under $prefix as well as $exec_prefix
Date: Sat, 12 May 2007 08:23:00 -0000	[thread overview]
Message-ID: <87k5ve78nb.fsf@firetop.home> (raw)
In-Reply-To: <20070511180543.GC1684@caradoc.them.org> (Daniel Jacobowitz's 	message of "Fri, 11 May 2007 14:05:43 -0400")

Daniel Jacobowitz <drow@false.org> writes:
> On Wed, May 02, 2007 at 11:32:18AM +0100, Richard Sandiford wrote:
>> Unfortunately, the current configure code only treats sysroots as
>> relocatable if they are subdirectories of --exec-prefix.  This seems
>> to be academic in the case of ld and gdb; they don't seem to take any
>> notice of TARGET_SYSTEM_ROOT_RELOCATABLE anyway.  (ld relies on the
>> relocation performed by the gcc driver.)
>
> GDB definitely does honor TARGET_SYSTEM_ROOT_RELOCATABLE.  ld does too
> (get_relative_sysroot in ldmain.c).

Doh!  Sorry, I must have grepped wrongly.  Probably for
DTARGET_SYSTEM_ROOT_RELOCATABLE or something that stupid like that.

>> This patch makes configure treat sysroots as relocatable if they are
>> under either --prefix or --exec-prefix.  I've updated the ld and gdb
>> versions to keep them in sync.
>> 
>> Bootstrapped & regression-tested on x86_64-linux-gnu.  Also tested
>> on a sysrooted mips-linux-gnu compiler.  OK to install?
>
> LD and GDB parts are OK.

Thanks.

> I think the GCC part is sufficiently obvious, or else ping Paolo.

I think "obvious" is a bit of a stretch in this case, so I'll hold
off the applying until the gcc part is reviewed.

Richard


  reply	other threads:[~2007-05-12  8:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-02 10:32 Richard Sandiford
2007-05-11 18:05 ` Daniel Jacobowitz
2007-05-12  8:23   ` Richard Sandiford [this message]
2007-05-14  0:17     ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k5ve78nb.fsf@firetop.home \
    --to=richard@codesourcery.com \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox