From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: one approach to fixing PR 14100
Date: Sat, 04 Aug 2012 01:58:00 -0000 [thread overview]
Message-ID: <87k3xfl8oj.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120803210203.GA21083@host2.jankratochvil.net> (Jan Kratochvil's message of "Fri, 3 Aug 2012 23:02:03 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> #5 0x00000000103e071c in internal_error (file=0x1065c308 "frame.c",
Jan> line=2396, string=0x1065c2e8 "%s: Assertion `%s' failed.") at
Jan> utils.c:882
Jan> #6 0x00000000103f12f4 in frame_cleanup_after_sniffer
Jan> (arg=0x100106162f0) at frame.c:2396
It's more useful to see where it was originally thrown; or to see what
sniffer is failing.
Jan> This patch could not be x86* regression tested.
It wasn't.
Jan> This is because dwarf2_tailcall_sniffer_first at the end of
Jan> dwarf2_frame_cache needs to have THIS_FRAME already finalized,
Jan> therefore with the cache, as it needs to access the previous
Jan> (unwound) frame.
Then we need a cleanup instead.
I'll look at it on Monday.
Tom
next prev parent reply other threads:[~2012-08-04 1:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 16:12 Tom Tromey
2012-08-03 16:03 ` Tom Tromey
2012-08-03 21:02 ` Jan Kratochvil
2012-08-04 1:58 ` Tom Tromey [this message]
2012-08-04 6:26 ` Jan Kratochvil
2012-08-06 15:31 ` Tom Tromey
2012-08-06 15:45 ` Jan Kratochvil
2012-08-09 9:42 ` Mark Kettenis
2012-08-09 9:46 ` Jan Kratochvil
2012-08-09 20:12 ` Tom Tromey
2012-08-08 18:27 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3xfl8oj.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox