Re: RFC: one approach to fixing PR 14100

Tom Tromey
2012-08-04T01:58:56Z

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> #5 0x00000000103e071c in internal_error (file=0x1065c308 "frame.c",
Jan> line=2396, string=0x1065c2e8 "%s: Assertion `%s' failed.") at
Jan> utils.c:882
Jan> #6 0x00000000103f12f4 in frame_cleanup_after_sniffer
Jan> (arg=0x100106162f0) at frame.c:2396

It's more useful to see where it was originally thrown; or to see what
sniffer is failing.

Jan> This patch could not be x86* regression tested.

It wasn't.

Jan> This is because dwarf2_tailcall_sniffer_first at the end of
Jan> dwarf2_frame_cache needs to have THIS_FRAME already finalized,
Jan> therefore with the cache, as it needs to access the previous
Jan> (unwound) frame.

Then we need a cleanup instead.
I'll look at it on Monday.

Tom