From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Rely on beneath to do partial xfer from tfile target
Date: Wed, 17 Jul 2013 19:57:00 -0000 [thread overview]
Message-ID: <87k3kpdknw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <514C291B.7010201@codesourcery.com> (Yao Qi's message of "Fri, 22 Mar 2013 17:49:15 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> +if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
Yao> + executable {debug nowarnings}] != "" } {
Yao> + untested read-memory.exp
Yao> + return -1
Yao> +}
Yao> +clean_restart $testfile
I think this can use prepare_for_testing.
Yao> + with_test_prefix "/wo setting traceframe" {
More normal is "w/o".
Yao> + with_test_prefix "/w setting traceframe" {
.. and "w/".
This occurs in a couple places.
The patch is ok with those fixes. Thanks.
Tom
next prev parent reply other threads:[~2013-07-17 19:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 11:40 Yao Qi
2013-03-20 11:57 ` Pedro Alves
2013-03-22 11:13 ` Yao Qi
2013-04-01 2:40 ` Yao Qi
2013-07-17 20:16 ` Tom Tromey
2013-07-18 23:10 ` Yao Qi
2013-04-08 17:02 ` Yao Qi
2013-07-17 19:57 ` Tom Tromey [this message]
2013-07-18 23:06 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3kpdknw.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox