From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103489-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4682 invoked by alias); 17 Jul 2013 19:57:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4673 invoked by uid 89); 17 Jul 2013 19:57:33 -0000
X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 17 Jul 2013 19:57:32 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6HJvOF7007886	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 17 Jul 2013 15:57:24 -0400
Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6HJvNsE003479	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 17 Jul 2013 15:57:23 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Rely on beneath to do partial xfer from tfile target
References: <1363774156-31949-1-git-send-email-yao@codesourcery.com>	<5149A022.7070302@redhat.com> <514C291B.7010201@codesourcery.com>
Date: Wed, 17 Jul 2013 19:57:00 -0000
In-Reply-To: <514C291B.7010201@codesourcery.com> (Yao Qi's message of "Fri, 22	Mar 2013 17:49:15 +0800")
Message-ID: <87k3kpdknw.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-07/txt/msg00429.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> +if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
Yao> +	  executable {debug nowarnings}] != "" } {
Yao> +    untested read-memory.exp
Yao> +    return -1
Yao> +}
Yao> +clean_restart $testfile

I think this can use prepare_for_testing.

Yao> +	with_test_prefix "/wo setting traceframe" {

More normal is "w/o".

Yao> +	with_test_prefix "/w setting traceframe" {

.. and "w/".

This occurs in a couple places.

The patch is ok with those fixes.  Thanks.

Tom