Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch][python] 2/3 Python representation of GDB line tables (Testsuite)
Date: Wed, 23 Oct 2013 20:53:00 -0000	[thread overview]
Message-ID: <87k3h3d802.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5253F4DD.4000104@redhat.com> (Phil Muldoon's message of "Tue, 08	Oct 2013 13:04:45 +0100")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> This patch in the series contains the testsuite code for Python
Phil> linetables.

Phil> diff --git a/gdb/testsuite/gdb.python/py-linetable.S
Phil> b/gdb/testsuite/gdb.python/py-linetable.S
Phil> new file mode 100644
Phil> index 0000000..5957222
Phil> --- /dev/null
Phil> +++ b/gdb/testsuite/gdb.python/py-linetable.S
Phil> @@ -0,0 +1,345 @@
Phil> +	.file	"py-linetable.c"
Phil> +	.text
Phil> +.Ltext0:

Normally we hack in a comment header at the top.

I wonder whether assembly is truly needed in this case.

Phil> +#
Phil> +# You should have received a copy of the GNU General Public License
Phil> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
Phil> +load_lib gdb-python.exp
Phil> +set opts {}
Phil> +standard_testfile .S

Blank line between comments and code.

Phil> +gdb_py_test_silent_cmd "python lt =
Phil> gdb.selected_frame().find_sal().symtab.linetable()" \

Your patch got wrapped.

Tom


  reply	other threads:[~2013-10-23 20:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 12:04 Phil Muldoon
2013-10-23 20:53 ` Tom Tromey [this message]
2013-11-07 15:46   ` Phil Muldoon
2013-11-07 16:07     ` Tom Tromey
2013-11-07 16:37   ` Phil Muldoon
2013-11-07 17:08     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3h3d802.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox