From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106622-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4563 invoked by alias); 23 Oct 2013 20:53:22 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4550 invoked by uid 89); 23 Oct 2013 20:53:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Oct 2013 20:53:20 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9NKrJ27007186	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 23 Oct 2013 16:53:19 -0400
Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9NKrIvq022160	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 23 Oct 2013 16:53:19 -0400
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch][python] 2/3 Python representation of GDB line tables (Testsuite)
References: <5253F4DD.4000104@redhat.com>
Date: Wed, 23 Oct 2013 20:53:00 -0000
In-Reply-To: <5253F4DD.4000104@redhat.com> (Phil Muldoon's message of "Tue, 08	Oct 2013 13:04:45 +0100")
Message-ID: <87k3h3d802.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-10/txt/msg00735.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> This patch in the series contains the testsuite code for Python
Phil> linetables.

Phil> diff --git a/gdb/testsuite/gdb.python/py-linetable.S
Phil> b/gdb/testsuite/gdb.python/py-linetable.S
Phil> new file mode 100644
Phil> index 0000000..5957222
Phil> --- /dev/null
Phil> +++ b/gdb/testsuite/gdb.python/py-linetable.S
Phil> @@ -0,0 +1,345 @@
Phil> +	.file	"py-linetable.c"
Phil> +	.text
Phil> +.Ltext0:

Normally we hack in a comment header at the top.

I wonder whether assembly is truly needed in this case.

Phil> +#
Phil> +# You should have received a copy of the GNU General Public License
Phil> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
Phil> +load_lib gdb-python.exp
Phil> +set opts {}
Phil> +standard_testfile .S

Blank line between comments and code.

Phil> +gdb_py_test_silent_cmd "python lt =
Phil> gdb.selected_frame().find_sal().symtab.linetable()" \

Your patch got wrapped.

Tom