Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/7] Split c_val_print
Date: Thu, 09 Jul 2015 23:42:00 -0000	[thread overview]
Message-ID: <87k2u8kie7.fsf@redhat.com> (raw)
In-Reply-To: <1436389629-18754-1-git-send-email-simon.marchi@ericsson.com>	(Simon Marchi's message of "Wed, 8 Jul 2015 17:07:02 -0400")

On Wednesday, July 08 2015, Simon Marchi wrote:

> I think that c_val_print deserves to be split up in smaller, more
> manageable chunks.  This series does that, by simply factoring out each
> case of the big switch.  In some cases, a bit of modifications were
> necessary where fallthrough between cases or goto were used, but
> otherwise the code stays the same.

Hey Simon,

Could you please take a look at the BuildBot results for your series?
I'm seeing some strange errors there, not sure if they were caused by
these patches or not.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


      parent reply	other threads:[~2015-07-09 23:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 21:08 Simon Marchi
2015-07-08 21:08 ` [PATCH 5/7] Factor out struct and union printing code from c_val_print Simon Marchi
2015-07-08 21:08 ` [PATCH 6/7] Factor out int " Simon Marchi
2015-07-08 21:08 ` [PATCH 4/7] Factor out pointer " Simon Marchi
2015-07-09 15:32   ` Simon Marchi
2015-07-08 21:08 ` [PATCH 3/7] Factor out array " Simon Marchi
2015-07-08 21:08 ` [PATCH 2/7] Factor out print_unpacked_pointer " Simon Marchi
2015-07-09 15:30   ` Simon Marchi
2015-07-08 21:08 ` [PATCH 7/7] Factor out memberptr printing code " Simon Marchi
2015-07-08 21:08 ` [PATCH 1/7] Remove unneeded variable assignment Simon Marchi
2015-07-09 10:53 ` [PATCH 0/7] Split c_val_print Pedro Alves
2015-07-09 15:28   ` Simon Marchi
2015-07-09 15:30     ` Pedro Alves
2015-07-09 23:42 ` Sergio Durigan Junior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2u8kie7.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox