From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106545 invoked by alias); 9 Jul 2015 23:42:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106536 invoked by uid 89); 9 Jul 2015 23:42:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Jul 2015 23:42:26 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 7041336B1A2; Thu, 9 Jul 2015 23:42:25 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t69NgO6Q017864 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 9 Jul 2015 19:42:25 -0400 From: Sergio Durigan Junior To: Simon Marchi Cc: Subject: Re: [PATCH 0/7] Split c_val_print References: <1436389629-18754-1-git-send-email-simon.marchi@ericsson.com> X-URL: http://blog.sergiodj.net Date: Thu, 09 Jul 2015 23:42:00 -0000 In-Reply-To: <1436389629-18754-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 8 Jul 2015 17:07:02 -0400") Message-ID: <87k2u8kie7.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00309.txt.bz2 On Wednesday, July 08 2015, Simon Marchi wrote: > I think that c_val_print deserves to be split up in smaller, more > manageable chunks. This series does that, by simply factoring out each > case of the big switch. In some cases, a bit of modifications were > necessary where fallthrough between cases or goto were used, but > otherwise the code stays the same. Hey Simon, Could you please take a look at the BuildBot results for your series? I'm seeing some strange errors there, not sure if they were caused by these patches or not. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/