From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,
Simon Marchi <simon.marchi@polymtl.ca>,
Steve Ellcey <sellcey@cavium.com>,
gdb-patches <gdb-patches@sourceware.org>,
simon.marchi@ericsson.com
Subject: Re: gdb build problem (gdb/unittests/scoped_mmap-selftests.c)
Date: Thu, 09 Aug 2018 14:34:00 -0000 [thread overview]
Message-ID: <87k1oz8v8r.fsf@tromey.com> (raw)
In-Reply-To: <ae60260c-e176-b846-ee04-a553ae5ee9a3@redhat.com> (Pedro Alves's message of "Thu, 9 Aug 2018 14:28:09 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 08/08/2018 06:56 PM, Tom Tromey wrote:
>> diff --git a/gdb/configure.ac b/gdb/configure.ac
>> index 13bc5f9a8f2..76a1ba0364f 100644
>> --- a/gdb/configure.ac
>> +++ b/gdb/configure.ac
>> @@ -2279,6 +2279,10 @@ dnl At the moment, we just assume it's UTF-8.
>> AC_DEFINE(GDB_DEFAULT_HOST_CHARSET, "UTF-8",
>> [Define to be a string naming the default host character set.])
>>
>> +AH_BOTTOM([#if defined __OPTIMIZE__ && __OPTIMIZE__ > 0
>> +#define _FORTIFY_SOURCE 2
>> +#endif])
Pedro> Do we really need to put this in config.h? Wouldn't putting it straight
Pedro> in common/common-defs.h work out the same? We already define
Pedro> __STDC_CONSTANT_MACRO etc. there before any system header.
That does seems simpler, and I think it will work just as well.
Tom
next prev parent reply other threads:[~2018-08-09 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 15:42 Steve Ellcey
2018-08-08 17:35 ` Tom Tromey
2018-08-08 17:39 ` Simon Marchi
2018-08-08 17:57 ` Tom Tromey
2018-08-08 22:17 ` Simon Marchi
2018-08-09 13:28 ` Pedro Alves
2018-08-09 14:34 ` Tom Tromey [this message]
2018-08-08 18:00 ` Tom Tromey
2018-08-08 17:49 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1oz8v8r.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=sellcey@cavium.com \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox