From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4361 invoked by alias); 9 Aug 2018 14:34:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4346 invoked by uid 89); 9 Aug 2018 14:34:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.38) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 14:34:36 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 0FD47174BF for ; Thu, 9 Aug 2018 09:34:35 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nm0jfyav6bXuJnm15fNMiY; Thu, 09 Aug 2018 09:34:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kbmlIPHNapH+wmqab+Omm9x2SqSeCxyMMJ3jiYS3jxs=; b=spEnH2Y4028t6iJtNU+Z2w4u8N 6CP1X0YivwxKn+1Mn5pTIPwAipLFCuFJjI9SAvRM8VMAC7/bOPvhRCKXPVdulFpPWFsLdTNsupkUV 20ehtpQmatGM7JezTi966OyFt; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:59032 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnm0j-001Oul-1v; Thu, 09 Aug 2018 09:33:57 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Simon Marchi , Steve Ellcey , gdb-patches , simon.marchi@ericsson.com Subject: Re: gdb build problem (gdb/unittests/scoped_mmap-selftests.c) References: <1533742957.31481.2.camel@cavium.com> <87wot092xy.fsf@tromey.com> <87sh3o91y2.fsf@tromey.com> Date: Thu, 09 Aug 2018 14:34:00 -0000 In-Reply-To: (Pedro Alves's message of "Thu, 9 Aug 2018 14:28:09 +0100") Message-ID: <87k1oz8v8r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00213.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 08/08/2018 06:56 PM, Tom Tromey wrote: >> diff --git a/gdb/configure.ac b/gdb/configure.ac >> index 13bc5f9a8f2..76a1ba0364f 100644 >> --- a/gdb/configure.ac >> +++ b/gdb/configure.ac >> @@ -2279,6 +2279,10 @@ dnl At the moment, we just assume it's UTF-8. >> AC_DEFINE(GDB_DEFAULT_HOST_CHARSET, "UTF-8", >> [Define to be a string naming the default host character set.]) >> >> +AH_BOTTOM([#if defined __OPTIMIZE__ && __OPTIMIZE__ > 0 >> +#define _FORTIFY_SOURCE 2 >> +#endif]) Pedro> Do we really need to put this in config.h? Wouldn't putting it straight Pedro> in common/common-defs.h work out the same? We already define Pedro> __STDC_CONSTANT_MACRO etc. there before any system header. That does seems simpler, and I think it will work just as well. Tom