From: Tom Tromey <tom@tromey.com>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/configure.ac: add --enable-source-highlight
Date: Fri, 15 Mar 2019 14:18:00 -0000 [thread overview]
Message-ID: <87k1h0b4ql.fsf@tromey.com> (raw)
In-Reply-To: <20190313215020.11959-1-slyfox@gentoo.org> (Sergei Trofimovich's message of "Wed, 13 Mar 2019 21:50:20 +0000")
>>>>> "Sergei" == Sergei Trofimovich <slyfox@gentoo.org> writes:
Sergei> Allow disabling source-highlight dependency autodetection even
Sergei> it exists in the system. More details on problem of automatic
Sergei> dependencies:
Sergei> https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies
Sergei> Noticed by Jeroen Roovers in https://bugs.gentoo.org/680238
Hi. Thank you for the patch.
This looks essentially fine to me. Do you have a copyright assignment
in place? (Though I wonder whether one is really needed, given that the
actual change here is pretty small.)
This probably could use some minor follow-on patches, e.g. for "show
configuration", but I'm happy to do those.
Tom
next prev parent reply other threads:[~2019-03-15 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 21:50 Sergei Trofimovich
2019-03-15 14:18 ` Tom Tromey [this message]
2019-03-17 22:47 ` Sergei Trofimovich
2019-03-17 22:48 ` [PATCH v2] " Sergei Trofimovich
2019-04-19 20:09 ` Tom Tromey
2019-03-18 3:52 ` [PATCH] " Sergio Durigan Junior
2019-03-18 16:02 ` Tom Tromey
2019-03-18 16:45 ` Eli Zaretskii
2019-03-18 17:10 ` Sergio Durigan Junior
2019-03-18 17:56 ` Eli Zaretskii
2019-03-18 16:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1h0b4ql.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox