From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58752 invoked by alias); 15 Mar 2019 14:18:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58744 invoked by uid 89); 15 Mar 2019 14:18:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=sk:source- X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Mar 2019 14:18:47 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 81A85B365 for ; Fri, 15 Mar 2019 09:18:46 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4nfXhCGSj4FKp4nfXhR87L; Fri, 15 Mar 2019 09:18:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PDq2mCnPIvweA07CWJxB2H7U1T/L79CIZXlCSfzTOas=; b=IwMxPodFG+HX6T8RooVR0HQ7Bw RQ3zAvcxuj6/UQBCWKrVhTBOYb3HEa4F44CtIAYOVbVQf16L1jj84NWxga/bIMSDIWrbD9tE4Mdnk JiRBOtRAzCJFEAUBhcYPjryvd; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:48980 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h4nfX-000CZh-Ec; Fri, 15 Mar 2019 09:18:43 -0500 From: Tom Tromey To: Sergei Trofimovich Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/configure.ac: add --enable-source-highlight References: <20190313215020.11959-1-slyfox@gentoo.org> Date: Fri, 15 Mar 2019 14:18:00 -0000 In-Reply-To: <20190313215020.11959-1-slyfox@gentoo.org> (Sergei Trofimovich's message of "Wed, 13 Mar 2019 21:50:20 +0000") Message-ID: <87k1h0b4ql.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00314.txt.bz2 >>>>> "Sergei" == Sergei Trofimovich writes: Sergei> Allow disabling source-highlight dependency autodetection even Sergei> it exists in the system. More details on problem of automatic Sergei> dependencies: Sergei> https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies Sergei> Noticed by Jeroen Roovers in https://bugs.gentoo.org/680238 Hi. Thank you for the patch. This looks essentially fine to me. Do you have a copyright assignment in place? (Though I wonder whether one is really needed, given that the actual change here is pretty small.) This probably could use some minor follow-on patches, e.g. for "show configuration", but I'm happy to do those. Tom