From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFAv2] Fix leak due to assigning a xstrdup-ed string to the std::string gdb_datadir
Date: Mon, 30 Sep 2019 21:23:00 -0000 [thread overview]
Message-ID: <87k19p7a2f.fsf@tromey.com> (raw)
In-Reply-To: <20190930195309.3338-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Mon, 30 Sep 2019 21:53:09 +0200")
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
Philippe> gdb/ChangeLog
Philippe> YYYY-MM-DD Philippe Waroquiers <philippe.waroquiers@skynet.be>
Philippe> * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
Philippe> conversion of gdb_datadir.
Philippe> (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
Philippe> remove not needed c_str ().
Thank you for doing this. This is ok.
Tom
prev parent reply other threads:[~2019-09-30 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 19:53 Philippe Waroquiers
2019-09-30 21:23 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k19p7a2f.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox