From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31004 invoked by alias); 30 Sep 2019 21:23:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30995 invoked by uid 89); 30 Sep 2019 21:23:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.53.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Sep 2019 21:23:24 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 5C9BB4010AB42 for ; Mon, 30 Sep 2019 15:16:39 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id F38cii9fnPUvSF38ciMSXA; Mon, 30 Sep 2019 16:23:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=17O1XzLaboXW9tCsygQCSIgQxqIi+9IM6p6dgwSULKo=; b=qo18B7CRq+a5OuWa/cvGUhiWEJ d+lbh12/cqdKDYGY3CY/Cb805CL6ObQJctmGONC4zjOOuQZZiQRSyLF1ljDFbN6APtiF0OO4kW1GU 5xtx2q5LAyz9Oh96fl8FztAYf; Received: from 75-166-72-156.hlrn.qwest.net ([75.166.72.156]:38726 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iF38b-003CS8-PH; Mon, 30 Sep 2019 15:23:21 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFAv2] Fix leak due to assigning a xstrdup-ed string to the std::string gdb_datadir References: <20190930195309.3338-1-philippe.waroquiers@skynet.be> Date: Mon, 30 Sep 2019 21:23:00 -0000 In-Reply-To: <20190930195309.3338-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Mon, 30 Sep 2019 21:53:09 +0200") Message-ID: <87k19p7a2f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00631.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> gdb/ChangeLog Philippe> YYYY-MM-DD Philippe Waroquiers Philippe> * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string Philippe> conversion of gdb_datadir. Philippe> (captured_main_1): Remove xstrdup when assigning to gdb_datadir, Philippe> remove not needed c_str (). Thank you for doing this. This is ok. Tom