From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix Ada crash with .debug_names
Date: Thu, 23 Apr 2020 07:16:08 -0600 [thread overview]
Message-ID: <87k126pckn.fsf@tromey.com> (raw)
In-Reply-To: <33a3c626-75f9-326e-55d9-b379635dd8bd@suse.de> (Tom de Vries's message of "Thu, 23 Apr 2020 14:43:06 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> it took me a while to realize that the problem is that the changed
Tom> return type of language_lookup_name caused a std::string copy
Tom> constructor to be invoked here:
Haha, me too!
Tom> Perhaps the log message could be extended to clarify that bit.
Good idea. I'm going to check it in with that change.
Tom
prev parent reply other threads:[~2020-04-23 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 15:23 Tom Tromey
2020-04-23 12:43 ` Tom de Vries
2020-04-23 13:16 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k126pckn.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox