From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tromey@adacore.com>
Received: from rock.gnat.com (rock.gnat.com
 [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1])
 by sourceware.org (Postfix) with ESMTP id 733C8385DC0C
 for <gdb-patches@sourceware.org>; Thu, 23 Apr 2020 13:16:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 733C8385DC0C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=tromey@adacore.com
Received: from localhost (localhost.localdomain [127.0.0.1])
 by filtered-rock.gnat.com (Postfix) with ESMTP id 22EEC1165DF;
 Thu, 23 Apr 2020 09:16:09 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at gnat.com
Received: from rock.gnat.com ([127.0.0.1])
 by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id aE2tc-k6T7gP; Thu, 23 Apr 2020 09:16:09 -0400 (EDT)
Received: from murgatroyd (184-96-229-138.hlrn.qwest.net [184.96.229.138])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by rock.gnat.com (Postfix) with ESMTPSA id B980A116475;
 Thu, 23 Apr 2020 09:16:08 -0400 (EDT)
From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix Ada crash with .debug_names
References: <20200421152335.21282-1-tromey@adacore.com>
 <33a3c626-75f9-326e-55d9-b379635dd8bd@suse.de>
X-Attribution: Tom
Date: Thu, 23 Apr 2020 07:16:08 -0600
In-Reply-To: <33a3c626-75f9-326e-55d9-b379635dd8bd@suse.de> (Tom de Vries's
 message of "Thu, 23 Apr 2020 14:43:06 +0200")
Message-ID: <87k126pckn.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Apr 2020 13:16:19 -0000

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> it took me a while to realize that the problem is that the changed
Tom> return type of language_lookup_name caused a std::string copy
Tom> constructor to be invoked here:

Haha, me too!

Tom> Perhaps the log message could be extended to clarify that bit.

Good idea.  I'm going to check it in with that change.

Tom