From: Tom Tromey <tom@tromey.com>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: timurgol007 <timurgol007@gmail.com>,
aburgess@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PING][PATCH v2] gdb/record: Support fense.tso, zicond, bitmanip, sinval and zihintntl in riscv
Date: Fri, 31 Oct 2025 11:54:12 -0600 [thread overview]
Message-ID: <87jz0bdkjf.fsf@tromey.com> (raw)
In-Reply-To: <dde2d95b-ac8b-4603-8da4-03b5caa9d4e0@redhat.com> (Guinevere Larsen's message of "Fri, 31 Oct 2025 14:37:25 -0300")
Guinevere> As far as I can see, this patch looks OK, so I'm fine with giving a
Guinevere> review tag
Guinevere> Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
Guinevere> I'll give this some more time for Andrew or someone with more RISC-V
Guinevere> knowledge to look over, rather than just saying you can push.
I would normally approve this on the basis that (1) RISC-V reviews don't
really seem to be happening, (2) you think it is ok, and (3) it only
affects record/replay.
However:
>> include/opcode/riscv-opc.h | 43 +++++++++++++++++++
...this affects other users so I don't know.
Perhaps opcode changes should be sent to the binutils list first.
Tom
next prev parent reply other threads:[~2025-10-31 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 11:39 timurgol007
2025-10-27 15:42 ` timurgol007
2025-10-27 15:42 ` [PATCH] gdb/record: Support fense.tso, zicond, bitmanip, sinval and zihintntl in RISC-V timurgol007
2025-10-31 17:37 ` [PING][PATCH v2] gdb/record: Support fense.tso, zicond, bitmanip, sinval and zihintntl in riscv Guinevere Larsen
2025-10-31 17:54 ` Tom Tromey [this message]
2025-11-21 19:45 ` [PATCH] gdb/record: Support fense.tso, zicond, bitmanip, sinval and zihintntl in RISC-V timurgol007
2025-10-27 16:17 [PING][PATCH v2] gdb/record: Support fense.tso, zicond, bitmanip, sinval and zihintntl in riscv Timur Golubovich
2025-10-27 17:23 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz0bdkjf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
--cc=timurgol007@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox