From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ermeN1v4BGmLZBUAWB0awg (envelope-from ) for ; Fri, 31 Oct 2025 13:56:43 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=d8fsSqIW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D4D941E04C; Fri, 31 Oct 2025 13:56:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E0C761E04C for ; Fri, 31 Oct 2025 13:56:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 85577385114C for ; Fri, 31 Oct 2025 17:56:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 85577385114C Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=d8fsSqIW Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 9EC4D3851141 for ; Fri, 31 Oct 2025 17:54:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9EC4D3851141 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9EC4D3851141 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761933255; cv=none; b=okixnBtPyREqBlcBrUMZdUxy5m9nuM73en9OAnlsE5PbMa9UEn+saQqp0xzIIn69dG0I94JlCfTbJvKUAdWsdkEA8Cb52ASzoHQLYC2l+Hc5JoqTloJV6PViVkF13+RP0SKtBbaOgWBxZLgY84ejYMSODgK6VGoDoj7lybBMM9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761933255; c=relaxed/simple; bh=7KtTk34PmPEZzLuBKBgSNVsxnk5e22WP3aJLYrMl3wo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hXYWp9nwpu8tCYd053xkPKMHsrhU/DOrGot7NUIKcaK+oIIUwKkiWcUa7PosVv+DwOLqgLrVqKk0SvzqRGYU+ZDK8zpfUXd+f+iGLGbhXkELWAWmPHrd866bbRw5U2exQkZiYweYSx9J2bzYfLNAq1WUoXfcMv4/Zo0zlr6h//g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9EC4D3851141 Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id EYNsvCrJBVCBNEtKIvZQrO; Fri, 31 Oct 2025 17:54:14 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id EtKHvR8DWMoIXEtKIvgGRl; Fri, 31 Oct 2025 17:54:14 +0000 X-Authority-Analysis: v=2.4 cv=R7wDGcRX c=1 sm=1 tr=0 ts=6904f7c6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zH7QHAUflxmhdRROgOAA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7KtTk34PmPEZzLuBKBgSNVsxnk5e22WP3aJLYrMl3wo=; b=d8fsSqIWTZVUqdrvfnytwRnk+u ZrWzNPW1XTmNcQ80s+AetAXru1ZrunGY27y5uJ4aeWsW5xVx5BaY7Vq77DmO0mvsCYJ7DwLhR5fLv e/O+9scvNm8dJ4NEXrjXcXUKx; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:55326 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vEtKH-000000014iN-1o1Z; Fri, 31 Oct 2025 11:54:13 -0600 From: Tom Tromey To: Guinevere Larsen Cc: timurgol007 , aburgess@redhat.com, gdb-patches@sourceware.org Subject: Re: [PING][PATCH v2] gdb/record: Support fense.tso, zicond, bitmanip, sinval and zihintntl in riscv In-Reply-To: (Guinevere Larsen's message of "Fri, 31 Oct 2025 14:37:25 -0300") References: <20251020113944.29912-1-timurgol007@gmail.com> X-Attribution: Tom Date: Fri, 31 Oct 2025 11:54:12 -0600 Message-ID: <87jz0bdkjf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vEtKH-000000014iN-1o1Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:55326 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAVtg1UKCXS2aw+Jhlbek3RJRGcWbtT6hroSHGZkdlcwaGqt2K148bPjmtQeGwD1TRKUbnTwK+eRFMfAq4wUCiDPT39xKgs1RgZ6TEuP1OjSo86SmJFP kdEOmFWDWPHQ3sYkQHNq49KioQg8WrvOq/AskF4aagjzT42HAfD6JWmijG5kbsYAkyBf3qGTpDZNon0O7Z35TVL/sw7WhwLRx3A= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere> As far as I can see, this patch looks OK, so I'm fine with giving a Guinevere> review tag Guinevere> Reviewed-By: Guinevere Larsen Guinevere> I'll give this some more time for Andrew or someone with more RISC-V Guinevere> knowledge to look over, rather than just saying you can push. I would normally approve this on the basis that (1) RISC-V reviews don't really seem to be happening, (2) you think it is ok, and (3) it only affects record/replay. However: >> include/opcode/riscv-opc.h | 43 +++++++++++++++++++ ...this affects other users so I don't know. Perhaps opcode changes should be sent to the binutils list first. Tom