Re: [PATCH] Make blockvector a little more self-contained

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> I honestly think that this typedef could be removed, that it would be
Simon> clearer to see "std::vector<CORE_ADDR>" in the code.

I'll send a separate patch to remove it.
Some spots should be using an array view anyway IMO.

>> +  /* We only want to iterate over the local symbols, not any
>> +     symbols in included symtabs.  */
>> +  for (struct symbol *sym : multidict_symbols ())
>> +    sym->relocate (objfile, offsets);

Simon> Do you know what the comment above refers to?  What are we doing special
Simon> to avoid iterating on the symbols in included symtabs?

I do not know.  I've removed this comment.

>> +  void relocate (struct objfile *objfile, const section_offsets &offsets);

Simon> The comment says "this blockvector", looks like a copy-pasto.

Yep.

Simon> Also, a struct symbol already knows its objfile (it has an objfile()
Simon> method) if it is objfile-owned, which should be the case here.  So it
Simon> seems superfluous to pass the objfile here.  Actually, the objfile
Simon> parameter is not even used in symbol::relocate.

I removed the parameter.

I'll check this in soon.

Tom