From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kev5NKEBHmmVQxQAWB0awg (envelope-from ) for ; Wed, 19 Nov 2025 12:42:57 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YLoaSTlb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D39AC1E0B6; Wed, 19 Nov 2025 12:42:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 788421E048 for ; Wed, 19 Nov 2025 12:42:57 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4940B385084F for ; Wed, 19 Nov 2025 17:42:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4940B385084F Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YLoaSTlb Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 1FFB63851170 for ; Wed, 19 Nov 2025 17:42:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FFB63851170 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1FFB63851170 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763574144; cv=none; b=ptJbNNy+OWD8SWrM+fIAWQUz/THIr4JCfiA8WXmCELTOqqj6fAtNtX8Xh6Mh+ggnb2rRC87s6Vrf+VnbOXZuuZYz1a12RNAow1uvf0sqE5ssiMb5J3tLELZdUkYVvQB54gUcw9YtPGFR7S0zRIL9cB0VcGI6+Abdk8qVZRBQPms= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763574144; c=relaxed/simple; bh=s2+hrWc0iyC4CcJmVo6BpHKV0dNDAJZxUZiSblrcshI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PFKCbwNYyaJAZd1ZHlkutHHSPJfjvX3PgnvPvt8KNaOG6+RbTO64c4wAKnfc4qxvRteP17xQ5ONGzinCPhCPHNRRz+6WIba3JtwLGBA5lU0e6pU3Vl0FKAGY3Xbd6LlQA8FH/Y69AMrxiEOLhheWUbQx0ucF47PXG6nt6nxRBD4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FFB63851170 Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id LjhEv75fdKXDJLmCFvBnk6; Wed, 19 Nov 2025 17:42:23 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id LmCEv9v8IY6MXLmCFvuiAu; Wed, 19 Nov 2025 17:42:23 +0000 X-Authority-Analysis: v=2.4 cv=eqLfzppX c=1 sm=1 tr=0 ts=691e017f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6UeiqGixMTsA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=YbLd5hGJzg7e0S5H8y0A:9 a=b4DR9a7p2ZdsqdHBznES:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3B2IsgTGXkKwfcUiw02J9mkx0NStJufjRbQA3J8Bk9U=; b=YLoaSTlbXUKgTiNNBhVgdifsQE NYHR85hC+avmPyvjaw62sS7+avRsS52RCr4871Pf57oWb3Fpn5kIZW6e5BDX3WF+s6sjvVntoaFjb SGYz0OuS+cM3qbCBHZTkyuGEX; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:58880 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vLmCE-00000001Pyp-1F4f; Wed, 19 Nov 2025 10:42:22 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Make blockvector a little more self-contained In-Reply-To: <86f2f3e7-15a5-4752-b2d6-4dc6ff7690a0@simark.ca> (Simon Marchi's message of "Wed, 19 Nov 2025 00:17:05 -0500") References: <20251119033033.3538090-1-tom@tromey.com> <86f2f3e7-15a5-4752-b2d6-4dc6ff7690a0@simark.ca> X-Attribution: Tom Date: Wed, 19 Nov 2025 10:42:21 -0700 Message-ID: <87jyzl9awy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vLmCE-00000001Pyp-1F4f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (prentzel) [97.122.120.205]:58880 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHTe0Pj646n/2AVypj/6GkGjsmO7TP/ZurqqXIkw4n8nARMPj15uHb0GvIv26qxF9+Jmp8Thnd4MFViy1L7X1wKH/9G3EpfryjU4R37wuQQU5392/TLY lfpYdqpeTGyMXL1Yx6+60CryzM5Ns++BVmQa1QJWl/INS4MZjBfawQqFyE3w2g7jghvIlkHVKA1YBxvHeWOZDjXnqrjzsn+z5sY= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> I honestly think that this typedef could be removed, that it would be Simon> clearer to see "std::vector" in the code. I'll send a separate patch to remove it. Some spots should be using an array view anyway IMO. >> + /* We only want to iterate over the local symbols, not any >> + symbols in included symtabs. */ >> + for (struct symbol *sym : multidict_symbols ()) >> + sym->relocate (objfile, offsets); Simon> Do you know what the comment above refers to? What are we doing special Simon> to avoid iterating on the symbols in included symtabs? I do not know. I've removed this comment. >> + void relocate (struct objfile *objfile, const section_offsets &offsets); Simon> The comment says "this blockvector", looks like a copy-pasto. Yep. Simon> Also, a struct symbol already knows its objfile (it has an objfile() Simon> method) if it is objfile-owned, which should be the case here. So it Simon> seems superfluous to pass the objfile here. Actually, the objfile Simon> parameter is not even used in symbol::relocate. I removed the parameter. I'll check this in soon. Tom