Re: [PATCH] gdb/tui: return std::string from tui_get_function_from_frame

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> I don't think there was anything particularly wrong with the old code,
> Andrew> but I'm not a huge fan of returning data in static buffers unless
> Andrew> there's a really good reason, and it doesn't feel like there's a
> Andrew> really good reason in this case.
>
> Definitely agree.  I feel like most such spots are artifacts of the C
> days, where the lack of RAII often meant trying to find a shortcut.
>
> Andrew>  /* Get a printable name for the function at the address.  The symbol
> Andrew>     name is demangled if demangling is turned on.  Returns a pointer to
> Andrew>     a static area holding the result.  */
> Andrew> -static char*
> Andrew> +static std::string
> Andrew>  tui_get_function_from_frame (const frame_info_ptr &fi)
>
> I think the comment needs a minor update.
>
> Andrew> +  size_t pos = name.find('(');
> Andrew> +  if (pos == std::string::npos)
> Andrew> +    pos = name.find('>');
> ...
> Andrew> +  if (pos != std::string::npos)
> Andrew> +    name.erase (pos);
> Andrew> +
> Andrew> +  pos = name.find('+');
>
> Some missing space-before-paren.
>
> Otherwise looks good.
> Approved-By: Tom Tromey <tom@tromey.com>

Fixed all the issues, and pushed.

Thanks,
Andrew