From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6M14C9tRc2lAOhEAWB0awg (envelope-from ) for ; Fri, 23 Jan 2026 05:47:55 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WBaeonU6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1B1A81E08D; Fri, 23 Jan 2026 05:47:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3EE781E08D for ; Fri, 23 Jan 2026 05:47:54 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AD7694BCA429 for ; Fri, 23 Jan 2026 10:47:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD7694BCA429 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WBaeonU6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 9FFBB4BC89B1 for ; Fri, 23 Jan 2026 10:47:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FFBB4BC89B1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FFBB4BC89B1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769165242; cv=none; b=hbYJ7onmZBUniU8OoqBIrTV27eLsXRFFshei4cBB5/1SGmpMVB9LJ5wDX25yQ9ypqPRy9nD8zTtILSdwqhk0c9aBdmQW/0hXRa4IBeHYLN1YgJf5FV2aF1/apw8au2zrOdn2U4TZ6CfF7fT/kRy86Ocwa8aUPQap40r2pv5p6hI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769165242; c=relaxed/simple; bh=62u/IS2bwIegjRCRVhRgYXsQ4LzVxF7SNJ57yg2sNvk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BgmhUGn8P0iK15+EnhVjamddeqDuojA0+lHA1Ql2t3QNPEU1hkncRQ9mgpsiCaoUmMaVbjFvzP/dRBoX1X5A2Bg7w8jqbAI8B5ZJsCpFfglLK8PCuKlnkrEN2gGQRVVeE/0agLzrFcrai03MO02Ct2pIfNjsFELDb084vgx55ds= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9FFBB4BC89B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769165242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dk2wZVGosj3sO76xbLYxpVj6LhrSjumLvEIeXk+bsus=; b=WBaeonU6D1JifgStEG9KZV5mte9/uBc3UePdGYu446060w1tlMMpJEYGT2xi/kedfgJlpB JV4i2iI+8kUkDl885KbKbeBWvzI711w/Jjm7jfD3nxxELtN4WzH7nOAGjdKfckXWljBDVc Vgbz1cg8qdelCbBHVg4iAT2Uefv0PnA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-AyzOeziJOlOyJFCQsi64Ew-1; Fri, 23 Jan 2026 05:47:21 -0500 X-MC-Unique: AyzOeziJOlOyJFCQsi64Ew-1 X-Mimecast-MFC-AGG-ID: AyzOeziJOlOyJFCQsi64Ew_1769165240 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47ee8808ffbso14904055e9.2 for ; Fri, 23 Jan 2026 02:47:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769165240; x=1769770040; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dk2wZVGosj3sO76xbLYxpVj6LhrSjumLvEIeXk+bsus=; b=ourjJj6pV2BTFbCfx0rP+qN+7T1Vm34YE6BPPyIAYAbfyFK57/4DZya8AoSzZPgMLl xctl9bx51xaQRLppBhJYgQv3wXmFquxJ7JDofjErwu6JoC83LNlN2P9g9u1TYOapxAav fvy8DW8LWWVWimMUH2ld6IE3QiMMVsjDpoHawCYaKlhAZf0K+DDsEgEgRabQMlwo07a5 PtLWn4jNTzpOowUSIeeYZFAUrUmCyFQW/FzBWWB+c1ZXceAMpkUs076sQ1ESlX2EMxte hsdDxm7w8t+wXSpM9W/Vbv7a6lrx5bWpFL7ccvnslFz2znaCQABveQNu8Vz2aoUl3Ujr NFFw== X-Gm-Message-State: AOJu0YysaL4zEIT/MSuVAQHYgZGBlyAjANqYDf2HaM5bnu+Iqyk47fJ6 CSg5ms8eL7kDQAH33YNJ5nW/KT/emC6rLsv+O4gHti71HRkHzwwVEETG+UpMWKb4sufgAhHlrv/ xX+NmAEomPZnqj+uhjNEMIqbb7vE99W2QOFSlYR9g7gV5Mc7Sb9MU9VzuPwCcAYHGekK5HLg= X-Gm-Gg: AZuq6aKk6lwXAEaFzydDtKROz5QWZBtg7QaSIvGs3k+yGxJGpTs/NLesik2R+nMljrP 7jAr7MU1kfw0wGHjk+mgfunBOu6pOebbDQQUyihgHRibki14mkHusXIV+oCXKH3eXNUWjazXMYl dWRfnxzXmIfB2oQarCXYZNhfjkUy1/rkycAhIMJTli5gUty3CPMIGWpbSqtAAjBxp+cjnb7YVhc DfYGtY5P2hAN2AnWsjh3lqhulB5jfvCyq0Gyups61g/68PhS/7NlbCWhL/xmuzWTp5TCNjygyWG SpxY9qzX/bGtcrfGSN15fcWdgqhadO6c84qtOv45HFEpCehQ0S8B9uVt4HeiAdsZjUev5AzagvE fiTFr X-Received: by 2002:a05:600c:4693:b0:480:1f6b:d495 with SMTP id 5b1f17b1804b1-4804c9bf396mr37870995e9.32.1769165239774; Fri, 23 Jan 2026 02:47:19 -0800 (PST) X-Received: by 2002:a05:600c:4693:b0:480:1f6b:d495 with SMTP id 5b1f17b1804b1-4804c9bf396mr37870695e9.32.1769165239320; Fri, 23 Jan 2026 02:47:19 -0800 (PST) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804d8c0aebsm46845395e9.15.2026.01.23.02.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 02:47:18 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/tui: return std::string from tui_get_function_from_frame In-Reply-To: <875x8t31gr.fsf@tromey.com> References: <32f9ecb06cced368b9f6433e9b4f38bad2e61d86.1769092070.git.aburgess@redhat.com> <875x8t31gr.fsf@tromey.com> Date: Fri, 23 Jan 2026 10:47:17 +0000 Message-ID: <87jyx8hah6.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 97EnLA4eNGyzPysJZPe2QS636W54KCdEoiFJyzoug0k_1769165240 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> I don't think there was anything particularly wrong with the old code, > Andrew> but I'm not a huge fan of returning data in static buffers unless > Andrew> there's a really good reason, and it doesn't feel like there's a > Andrew> really good reason in this case. > > Definitely agree. I feel like most such spots are artifacts of the C > days, where the lack of RAII often meant trying to find a shortcut. > > Andrew> /* Get a printable name for the function at the address. The symbol > Andrew> name is demangled if demangling is turned on. Returns a pointer to > Andrew> a static area holding the result. */ > Andrew> -static char* > Andrew> +static std::string > Andrew> tui_get_function_from_frame (const frame_info_ptr &fi) > > I think the comment needs a minor update. > > Andrew> + size_t pos = name.find('('); > Andrew> + if (pos == std::string::npos) > Andrew> + pos = name.find('>'); > ... > Andrew> + if (pos != std::string::npos) > Andrew> + name.erase (pos); > Andrew> + > Andrew> + pos = name.find('+'); > > Some missing space-before-paren. > > Otherwise looks good. > Approved-By: Tom Tromey Fixed all the issues, and pushed. Thanks, Andrew