From: Tom Tromey <tom@tromey.com>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb/dwarf: change signatured_type_up to include deleter type
Date: Thu, 21 May 2026 08:19:19 -0600 [thread overview]
Message-ID: <87jyswalqw.fsf@tromey.com> (raw)
In-Reply-To: <20260520182101.4074675-1-simon.marchi@polymtl.ca> (simon marchi's message of "Wed, 20 May 2026 14:19:28 -0400")
>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
Simon> If we give signatured_type_up the same deleter as dwarf2_per_cu_up, then
Simon> it becomes possible to pass a signatured_type_up as a dwarf2_per_cu_up.
Simon> This lets us avoid releasing a signatured_type_up only to create a
Simon> dwarf2dwarf2_per_cu_up immediately after in some spots. The only
Simon> downside is that we can't use make_unique anymore, but it's already the
Simon> case for dwarf2_per_cu_up.
Simon> Swap the order of things in add_type_unit so that we don't need a
Simon> special holder variable.
Looks reasonable to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-05-21 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 18:19 simon.marchi
2026-05-20 18:19 ` [PATCH 2/2] gdb/dwarf: track whether the all_units vector is sorted simon.marchi
2026-05-21 14:25 ` Tom Tromey
2026-05-21 17:45 ` Simon Marchi
2026-05-21 14:19 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyswalqw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox