From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb/dwarf: track whether the all_units vector is sorted
Date: Thu, 21 May 2026 13:45:59 -0400 [thread overview]
Message-ID: <095b575b-40b3-4407-8fca-6b38fb94d353@polymtl.ca> (raw)
In-Reply-To: <87fr3kalgi.fsf@tromey.com>
On 5/21/26 10:25 AM, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> Note that the flag is cleared when appending a unit even if the vector
> Simon> would by chance already be sorted. This is good, because it will catch
> Simon> mistakes even on machines where a problem with std::lower_bound would
> Simon> not manifest.
>
> Simon> I checked that this patch would have caught the problem before commit
> Simon> fbaef7de7701:
>
> Simon> (gdb) file /home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.dwarf2/debug-names-bad-cu-index/debug-names-bad-cu-index
> Simon> Reading symbols from /home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.dwarf2/debug-names-bad-cu-index/debug-names-bad-cu-index...
> Simon> /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:18092: internal-error: dwarf2_find_unit: Assertion `per_bfd->all_units_sorted' failed.
>
> Thanks, and especially for checking this.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Thanks, pushed both patches.
Simon
next prev parent reply other threads:[~2026-05-21 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 18:19 [PATCH 1/2] gdb/dwarf: change signatured_type_up to include deleter type simon.marchi
2026-05-20 18:19 ` [PATCH 2/2] gdb/dwarf: track whether the all_units vector is sorted simon.marchi
2026-05-21 14:25 ` Tom Tromey
2026-05-21 17:45 ` Simon Marchi [this message]
2026-05-21 14:19 ` [PATCH 1/2] gdb/dwarf: change signatured_type_up to include deleter type Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=095b575b-40b3-4407-8fca-6b38fb94d353@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox