From: Richard Sandiford <rsandifo@nildram.co.uk>
To: Thiemo Seufer <ths@networkno.de>
Cc: gdb-patches@sourceware.org
Subject: Re: MIPS32R2 simulator fixes
Date: Mon, 22 Oct 2007 20:22:00 -0000 [thread overview]
Message-ID: <87ir4yudbl.fsf@firetop.home> (raw)
In-Reply-To: <20071022120918.GB25397@networkno.de> (Thiemo Seufer's message of "Mon\, 22 Oct 2007 13\:09\:18 +0100")
Thiemo Seufer <ths@networkno.de> writes:
> Richard Sandiford wrote:
>> - The MIPS32R2 version of check_fmt_p checks UX and PX, but those
>> flags are always read as 0 on MIPS32R2 targets. There isn't
>> AFAIK any way of turning off paired-single instructions when
>> using a MIPS32R2 target that has a 64-bit FPU.
>
> It is correct that there's no separate switch to disable paired single
> when the MIPS-3D ASE is implemented. There is, however, the 3D bit in
> FCR0 which announces the availablity of paired single instructions,
> it should be set for the MIPS32R2/MIPS64* emulations.
OK.
>> sim/mips/
>> * mips.igen (check_fmt_p): Provide a separate mips32r2 definition
>> that unconditionally allows fmt_ps.
>> (ALNV.PS, CEIL.L.fmt, CVT.L.fmt, CVT.PS.S, CVT.S.PL, CVT.S.PU)
>> (FLOOR.L.fmt, LWXC1, MADD.fmt, MSUB.fmt, NMADD.fmt, NMSUB.fmt)
>> (PLL.PS, PLU.PS, PUL.PS, PUU.PS, ROUND.L.fmt, TRUNC.L.fmt): Change
>> filter from 64,f to 32,f.
>> (PREFX): Change filter from 64 to 32.
>> (LDXC1, LUXC1): Provide separate mips32r2 implementations
>> that use do_load_double instead of do_load. Make both LUXC1
>> versions unpredictable if SizeFGR () != 64.
>> (SDXC1, SUXC1): Extend to mips32r2, using do_store_double
>> instead of do_store. Remove unused variable. Make both SUXC1
>> versions unpredictable if SizeFGR () != 64.
>
> Looks good.
Applied, thanks.
Richard
prev parent reply other threads:[~2007-10-22 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 11:43 Richard Sandiford
2007-10-22 13:42 ` Thiemo Seufer
2007-10-22 20:22 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ir4yudbl.fsf@firetop.home \
--to=rsandifo@nildram.co.uk \
--cc=gdb-patches@sourceware.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox