From: Tom Tromey <tromey@redhat.com>
To: Kaushik Phatak <Kaushik.Phatak@kpitcummins.com>
Cc: Pedro Alves <palves@redhat.com>,
"binutils\@sourceware.org" <binutils@sourceware.org>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA] New port: CR16: BFD Changes required by the gdb port
Date: Wed, 02 Jan 2013 14:19:00 -0000 [thread overview]
Message-ID: <87ip7fekgy.fsf@fleche.redhat.com> (raw)
In-Reply-To: <C6CA53A2A46BA7469348BDBD663AB6584856466C@KCHJEXMB02.kpit.com> (Kaushik Phatak's message of "Fri, 28 Dec 2012 12:18:10 +0000")
>>>>> "Kaushik" == Kaushik Phatak <Kaushik.Phatak@kpitcummins.com> writes:
Pedro> It'd be nice if all these exported symbols were prefixed, to avoid
Pedro> namespace collisions.
Kaushik> I have added 'cr16_' as a prefix to all these exported symbols.
Kaushik> (make_instruction,match_opcode): Added function prototypes.
What about these?
Kaushik> /* Current opcode table entry we're disassembling. */
Kaushik> const inst *instruction;
I don't know opcodes, but it seems to me that it is best if a library
either makes symbols static or gives them a name prefix.
Otherwise you are going to run into clashes at link time.
Tom
prev parent reply other threads:[~2013-01-02 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 7:04 Kaushik Phatak
2012-12-14 18:52 ` Pedro Alves
2012-12-28 12:18 ` Kaushik Phatak
2013-01-02 13:14 ` nick clifton
2013-01-03 11:16 ` Kaushik Phatak
2013-01-07 15:11 ` nick clifton
2013-01-08 11:24 ` Kaushik Phatak
2013-01-08 17:54 ` Pedro Alves
2013-01-15 9:24 ` Kaushik Phatak
2013-01-02 14:19 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ip7fekgy.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=Kaushik.Phatak@kpitcummins.com \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox