From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14838 invoked by alias); 2 Jan 2013 14:19:21 -0000 Received: (qmail 14817 invoked by uid 22791); 2 Jan 2013 14:19:19 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Jan 2013 14:19:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r02EJBoA021944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Jan 2013 09:19:11 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r02EJ9Xj022668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 2 Jan 2013 09:19:10 -0500 From: Tom Tromey To: Kaushik Phatak Cc: Pedro Alves , "binutils\@sourceware.org" , "gdb-patches\@sourceware.org" , Joel Brobecker Subject: Re: [RFA] New port: CR16: BFD Changes required by the gdb port References: <50CB6CA4.1060901@redhat.com> Date: Wed, 02 Jan 2013 14:19:00 -0000 In-Reply-To: (Kaushik Phatak's message of "Fri, 28 Dec 2012 12:18:10 +0000") Message-ID: <87ip7fekgy.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00017.txt.bz2 >>>>> "Kaushik" == Kaushik Phatak writes: Pedro> It'd be nice if all these exported symbols were prefixed, to avoid Pedro> namespace collisions. Kaushik> I have added 'cr16_' as a prefix to all these exported symbols. Kaushik> (make_instruction,match_opcode): Added function prototypes. What about these? Kaushik> /* Current opcode table entry we're disassembling. */ Kaushik> const inst *instruction; I don't know opcodes, but it seems to me that it is best if a library either makes symbols static or gives them a name prefix. Otherwise you are going to run into clashes at link time. Tom