From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Update doc on displayhint in command -var-list-children
Date: Tue, 19 Nov 2013 17:05:00 -0000 [thread overview]
Message-ID: <87iovomjwn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1384860516-6949-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Tue, 19 Nov 2013 19:28:35 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> When using command -var-list-children, "displayhint" is the result of
Yao> each child, instead of the attribute of the result, shown as the
Yao> following output.
This seems wrong to me.
If a varobj has a pretty-printer, then the display hint is an attribute
of that printer. It ought to be printed as an attribute of the result.
Of course, child objects can have their own pretty-printers, and thus
their own display hints.
I couldn't find any tests that explicitly examined the display hint.
That seems wrong too... I know the python code in the test suite returns
values here, but nothing seems to check them.
Tom
next prev parent reply other threads:[~2013-11-19 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 11:39 Yao Qi
2013-11-19 11:31 ` [PATCH 2/2] Doc 'dynamic' for " Yao Qi
2013-11-19 16:17 ` Eli Zaretskii
2013-11-21 3:52 ` Yao Qi
2013-11-19 16:22 ` [PATCH 1/2] Update doc on displayhint in " Eli Zaretskii
2013-11-19 17:05 ` Tom Tromey [this message]
2013-11-20 2:16 ` Yao Qi
2013-11-22 20:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iovomjwn.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox