From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19876 invoked by alias); 19 Nov 2013 16:33:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19855 invoked by uid 89); 19 Nov 2013 16:33:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2013 16:33:07 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJGWwLg020793 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 19 Nov 2013 11:32:58 -0500 Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAJGWvf1012662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 19 Nov 2013 11:32:57 -0500 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 1/2] Update doc on displayhint in command -var-list-children References: <1384860516-6949-1-git-send-email-yao@codesourcery.com> Date: Tue, 19 Nov 2013 17:05:00 -0000 In-Reply-To: <1384860516-6949-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Tue, 19 Nov 2013 19:28:35 +0800") Message-ID: <87iovomjwn.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00553.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> When using command -var-list-children, "displayhint" is the result of Yao> each child, instead of the attribute of the result, shown as the Yao> following output. This seems wrong to me. If a varobj has a pretty-printer, then the display hint is an attribute of that printer. It ought to be printed as an attribute of the result. Of course, child objects can have their own pretty-printers, and thus their own display hints. I couldn't find any tests that explicitly examined the display hint. That seems wrong too... I know the python code in the test suite returns values here, but nothing seems to check them. Tom