Re: [PATCH 3/3] Add DWARF index cache

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> - The cache is disabled by default.  I think once it's been out there
Simon>   and tested for a while, it could be turned on by default, so that
Simon>   everybody can enjoy it.

I think the patch to enable it should also come with a patch to disable
it in the test suite, since otherwise "make check" is going to fill up
the cache and maybe have other unintended consequences.

Simon> +static void
Simon> +set_index_cache_command (const char *arg, int from_tty)
Simon> +{
Simon> +  printf_unfiltered ("\
Simon> +Missing arguments.  See \"help set index-cache\" for help.\n");

This probably needs _().  I think there were a couple other
(non-debug-print) cases of this as well.

Simon> +  printf_unfiltered ("The index cache is currently %s.\n",
Simon> +		   global_index_cache.enabled () ? "enabled" : "disabled");

Like here.

Simon> +static void
Simon> +test_mkdir_recursive ()
Simon> +{
Simon> +  char base[] = "/tmp/gdb-selftests-XXXXXX";
Simon> +
Simon> +  if (mkdtemp (base) == NULL)
Simon> +    perror_with_name ("mkdtemp");
Simon> +
Simon> +  std::string dir = string_printf ("%s/a/b", base);
Simon> +  SELF_CHECK (create_dir_and_check (dir.c_str ()));
Simon> +
Simon> +  dir = string_printf ("%s/a/b/c//d/e/", base);
Simon> +  SELF_CHECK (create_dir_and_check (dir.c_str ()));

It would be nice to clean up afterward.

Simon> diff --git a/gdb/dwarf-index-write.h b/gdb/dwarf-index-write.h
[...]
Simon> +void write_psymtabs_to_index (struct dwarf2_per_objfile *dwarf2_per_objfile,
Simon> +			      const char *dir, const char *basename,
Simon> +			      dw_index_kind index_kind);

I tend to prefer the explicit "extern" but I don't know if there's an
official style.


This patch seems fine to me and I like this feature -- I would use it
for sure.

I think it needs a doc + NEWS patch.

I think it would be good to file bugs for the future features you
mentioned in the email.

Tom