Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Tom Tromey <tom@tromey.com>,  <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Add DWARF index cache
Date: Wed, 18 Jul 2018 18:20:00 -0000	[thread overview]
Message-ID: <87a7qo5rsp.fsf@tromey.com> (raw)
In-Reply-To: <d3469129-1c96-8388-09bc-0d4c427b55f9@ericsson.com> (Simon	Marchi's message of "Tue, 17 Jul 2018 16:48:15 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> Good point.  This is already done in do_set_command, because the parameter is of
Simon> type var_filename.

I totally forgot about this :}

Simon> So here's what I changed:

Simon> - Make get_standard_cache_dir return an absolute, tilde-expanded path.
Simon> - Make set_index_cache_directory_command transform index_cache_directory so it is
Simon>   absolute and tilde-expanded.

Thank you for doing this

Tom


  reply	other threads:[~2018-07-18 18:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 21:56 [PATCH 0/3] Add a " Simon Marchi
2018-07-09 21:56 ` [PATCH 1/3] Make index reading functions more modular Simon Marchi
2018-07-25 16:51   ` Tom Tromey
2018-07-09 21:56 ` [PATCH 2/3] Introduce scoped_mmapped_file Simon Marchi
2018-07-24  2:18   ` Tom Tromey
2018-07-24 12:31     ` Simon Marchi
2018-07-09 21:57 ` [PATCH 3/3] Add DWARF index cache Simon Marchi
2018-07-17 19:48   ` Tom Tromey
2018-07-17 20:48     ` Simon Marchi
2018-07-18 18:20       ` Tom Tromey [this message]
2018-07-25 18:48   ` Tom Tromey
2018-07-25 20:20     ` Simon Marchi
2018-07-26 12:38     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7qo5rsp.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox