Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output)
Date: Wed, 05 Jun 2019 20:27:00 -0000	[thread overview]
Message-ID: <87imtjhj6b.fsf@tromey.com> (raw)
In-Reply-To: <b0299d9c-22d8-de30-72b5-99de4605d5dd@redhat.com> (Pedro Alves's	message of "Wed, 5 Jun 2019 19:12:21 +0100")

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> Prototype time!

Nice.

Pedro> I reserved "%pS" and "%pN" for styling, but haven't really prototyped that.
Pedro> Is there a global current style stack we can push a style to/from?

No, there's only a way to set the current style.  However, it's not
really intended for callers to set the style and then just leave it set
-- all the existing calls should set the style, then later set it back
to the default style.

It seems to me that this could be enforced by our printf.  Or, if we
really do want stacking, the stack could just be local to this function.

I wouldn't mind some kind of brackets being used as the characters here,
like %p[ ... %p].  It's too bad that we still have to pass some pointer
value for the closer.

Tom


  reply	other threads:[~2019-06-05 20:27 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05  2:01 [PATCH] Style "pwd" output Tom Tromey
2019-06-05  8:36 ` Pedro Alves
2019-06-05 13:42   ` Tom Tromey
2019-06-05 15:21     ` Pedro Alves
2019-06-05 18:12       ` ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output) Pedro Alves
2019-06-05 20:27         ` Tom Tromey [this message]
2019-06-05 20:39           ` Pedro Alves
2019-06-05 20:42             ` Pedro Alves
2019-06-05 20:49               ` Tom Tromey
2019-06-05 20:47             ` Tom Tromey
2019-06-05 21:25               ` Pedro Alves
2019-06-05 22:21                 ` Tom Tromey
2019-06-06 15:49                   ` Pedro Alves
2019-06-06 23:55                     ` Tom Tromey
2019-06-07 18:27                   ` Tom Tromey
2019-06-07 19:20                     ` Tom Tromey
2019-07-01 12:23                       ` Pedro Alves
2019-07-01 12:55                         ` Pedro Alves
2019-07-01 13:06                           ` Pedro Alves
2019-07-01 17:26                             ` Tom Tromey
2019-07-01 19:24                               ` [users/palves/format_strings] Down with .ptr() (Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output)) Pedro Alves
2019-07-01 13:17                           ` ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output) Pedro Alves
2019-07-01 13:20                             ` Pedro Alves
2019-07-01 17:38                             ` Tom Tromey
2019-07-01 18:49                               ` Tom Tromey
2019-07-01 18:56                                 ` Pedro Alves
2019-07-01 19:30                                   ` [users/palves/format_strings] Document the gdb-specific formatters Pedro Alves
2019-07-01 19:25                               ` [users/palves/format_strings] Introduce string_field Pedro Alves
2019-07-01 17:43                         ` ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output) Tom Tromey
2019-07-01 19:29                           ` [users/palves/format_strings] Make printf_filtered support the gdb-specific formatters too Pedro Alves
2019-07-01 12:01                     ` ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output) Pedro Alves
2019-07-01 12:25                       ` Tom Tromey
2019-07-01 12:37                         ` Pedro Alves
2019-07-01 17:20                           ` Tom Tromey
2019-07-01 19:27                             ` [users/palves/format_strings] %pS/%pN -> %p[/%p] Pedro Alves
2019-07-01 19:32                         ` ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output) Philippe Waroquiers
2019-07-03 12:20                           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imtjhj6b.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox