From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFC][gdb/symtab] Lazy expansion of full symbol table
Date: Tue, 15 Jun 2021 07:26:20 -0600 [thread overview]
Message-ID: <87im2fxnr7.fsf@tromey.com> (raw)
In-Reply-To: <533bf7e4-d96c-a6b7-8c37-a4141ebdc761@suse.de> (Tom de Vries's message of "Tue, 15 Jun 2021 01:36:49 +0200")
>> I don't have this executable
Tom> Uploaded to https://ftp.suse.com/pub/people/tdevries/gdb/pr23710/cc1
Thanks, I grabbed it.
>> but FWIW my scanner rewrite is ~10x faster
>> than the current psymtab reader.
Tom> Interesting, that's
Tom> https://github.com/tromey/gdb/commits/submit/no-more-psym ?
Tom> I've tried that branch with the cc1 example, and ran into:
Tom> ...
Tom> DW_FORM_strp pointing outside of .debug_str section [in module cc1]
Thank you for trying it. This was a bug in the CU importing code. I've
fixed it and will push momentarily -- but be warned, I rebase this
branch a lot...
On my machine, with "maint time 1", /bin/gdb reports:
(gdb) file ./cc1
2021-06-15 07:18:29.554 - command started
Reading symbols from ./cc1...
2021-06-15 07:18:35.118 - command finished
Command execution time: 5.553344 (cpu), 5.563964 (wall)
The branch says:
(gdb) file ./cc1
2021-06-15 07:18:50.688 - command started
Reading symbols from ./cc1...
2021-06-15 07:18:51.074 - command finished
Command execution time: 1.260050 (cpu), 0.386460 (wall)
So a bit more than 10x in this case. I wish it were a tiny bit faster,
so that it wasn't perceptible, but meh, DWARF wasn't designed to be fast
to read.
Currently I think the scanner is complete, I just need to make some
changes to the lookup code, and maybe also how the new index entries are
stored, so that completion is more efficient. Of course there may still
be bugs, but at the moment I don't anticipate any reader slowdowns.
Tom
next prev parent reply other threads:[~2021-06-15 13:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 9:39 Tom de Vries
2021-06-14 20:54 ` Tom Tromey
2021-06-14 23:36 ` Tom de Vries
2021-06-15 13:26 ` Tom Tromey [this message]
2021-06-16 10:20 ` Tom de Vries
2021-06-18 2:30 ` Tom Tromey
2021-06-19 19:36 ` Tom de Vries
2021-06-20 9:41 ` Tom de Vries
2021-06-20 18:17 ` Tom Tromey
2021-06-22 9:16 ` Tom de Vries
2021-06-20 23:44 ` Tom Tromey
2021-06-21 9:18 ` Tom de Vries
2021-06-27 22:24 ` Tom Tromey
2021-06-28 0:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im2fxnr7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox